Skip to content

before_send callback shouldn't be applied to transaction events#1167

Merged
st0012 merged 2 commits intomasterfrom
ignore-transaction-events-in-before-send
Dec 23, 2020
Merged

before_send callback shouldn't be applied to transaction events#1167
st0012 merged 2 commits intomasterfrom
ignore-transaction-events-in-before-send

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Dec 23, 2020

No description provided.

@st0012 st0012 added the bug fix label Dec 23, 2020
@st0012 st0012 added this to the 4.1.2 milestone Dec 23, 2020
@st0012 st0012 self-assigned this Dec 23, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 23, 2020 •
edited
Loading

Codecov Report

Merging #1167 (3f67e2e) into master (4a01031) will increase coverage by 0.50%.
The diff coverage is 97.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1167      +/-   ##
==========================================
+ Coverage   97.86%   98.36%   +0.50%     
==========================================
  Files         191       96      -95     
  Lines        7964     4162    -3802     
==========================================
- Hits         7794     4094    -3700     
+ Misses        170       68     -102
Impacted Files Coverage Δ
sentry-ruby/spec/sentry/client_spec.rb 96.26% <96.96%> (-0.08%) ⬇️
sentry-ruby/lib/sentry/client.rb 95.74% <100.00%> (+0.09%) ⬆️
...ntry-raven/spec/raven/processors/post_data_spec.rb
sentry-raven/lib/raven/integrations/delayed_job.rb
...y-raven/spec/raven/processors/http_headers_spec.rb
sentry-raven/lib/raven/transports/http.rb
...y-raven/lib/raven/integrations/rails/active_job.rb
sentry-raven/spec/raven/integrations/rake_spec.rb
...try-raven/lib/raven/interfaces/single_exception.rb
sentry-raven/lib/raven/integrations/sidekiq.rb
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a01031...3f67e2e. Read the comment docs.

@st0012 st0012 merged commit 17ef766 into master Dec 23, 2020
@st0012 st0012 deleted the ignore-transaction-events-in-before-send branch December 23, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@st0012 st0012

Labels

None yet

Projects

None yet

Milestone

4.1.2

Development

Successfully merging this pull request may close these issues.

2 participants

@st0012 @codecov-io