Skip to content

Fix NoMethodError when sending is not allowed#1161

Merged
st0012 merged 1 commit intomasterfrom
fix-event-not-allow
Dec 18, 2020
Merged

Fix NoMethodError when sending is not allowed#1161
st0012 merged 1 commit intomasterfrom
fix-event-not-allow

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Dec 18, 2020

Here's a full description of the issue #1147 (comment)

Stacktraces copied from the comment:

     NoMethodError:
       undefined method `event_id' for false:FalseClass
     Shared Example Group: "an unauthorized response" called from ./spec/requests/webhooks/slack_spec.rb:390
     # /usr/local/var/rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sentry-ruby-4.1.0/lib/sentry/hub.rb:113:in `capture_event'
     # /usr/local/var/rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sentry-ruby-4.1.0/lib/sentry/hub.rb:85:in `capture_exception'
     # /usr/local/var/rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sentry-ruby-4.1.0/lib/sentry-ruby.rb:119:in `capture_exception'
     # /usr/local/var/rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sentry-ruby-4.1.0/lib/sentry/rack/capture_exceptions.rb:28:in `rescue in block in call'
     # /usr/local/var/rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sentry-ruby-4.1.0/lib/sentry/rack/capture_exceptions.rb:22:in `block in call'
     # /usr/local/var/rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sentry-ruby-4.1.0/lib/sentry/hub.rb:50:in `with_scope'
     # /usr/local/var/rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sentry-ruby-4.1.0/lib/sentry-ruby.rb:103:in `with_scope'
     # /usr/local/var/rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sentry-ruby-4.1.0/lib/sentry/rack/capture_exceptions.rb:14:in `call'
     # /usr/local/var/rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/rack-cors-1.1.1/lib/rack/cors.rb:100:in `call'
     # /usr/local/var/rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/railties-6.0.3.4/lib/rails/engine.rb:527:in `call'
     # /usr/local/var/rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/rack-test-1.1.0/lib/rack/mock_session.rb:29:in `request'
     # /usr/local/var/rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/rack-test-1.1.0/lib/rack/test.rb:266:in `process_request'
     # /usr/local/var/rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/rack-test-1.1.0/lib/rack/test.rb:119:in `request'
     # /usr/local/var/rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/actionpack-6.0.3.4/lib/action_dispatch/testing/integration.rb:270:in `process'
     # /usr/local/var/rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/actionpack-6.0.3.4/lib/action_dispatch/testing/integration.rb:24:in `post'
     # /usr/local/var/rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/actionpack-6.0.3.4/lib/action_dispatch/testing/integration.rb:359:in `block (2 levels) in <module:Runner>'

@st0012
Fix NoMethodError when sending is not allowed
7e3c2e6 
Here's a full description on the issue
#1147 (comment)
@st0012 st0012 added the bug fix label Dec 18, 2020
@st0012 st0012 added this to the 4.1.1 milestone Dec 18, 2020
@st0012 st0012 self-assigned this Dec 18, 2020
@st0012 st0012 mentioned this pull request Dec 18, 2020
Merged
@st0012 st0012 merged commit 41982b1 into master Dec 18, 2020
@st0012 st0012 deleted the fix-event-not-allow branch December 18, 2020 16:08
@djberg96 djberg96 mentioned this pull request Oct 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@st0012 st0012

Labels

None yet

Projects

None yet

Milestone

4.1.1

Development

Successfully merging this pull request may close these issues.

1 participant

@st0012