Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1155 +/- ##
==========================================
+ Coverage 97.79% 98.28% +0.49%
==========================================
Files 187 94 -93
Lines 7840 4078 -3762
==========================================
- Hits 7667 4008 -3659
+ Misses 173 70 -103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5f1b4b1 to
24cec30
Compare
HazAT
approved these changes
Dec 17, 2020
Member
HazAT
left a comment
There was a problem hiding this comment.
LGTM, I'll add @bruno-garcia for a second pair of eyes
a48bf69 to
d66c36c
Compare
bruno-garcia
approved these changes
Dec 18, 2020
Member
bruno-garcia
left a comment
There was a problem hiding this comment.
LGTM. Very nice and simple
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For users who don't use
config.async, sending events is currently a blocking operation. This means a request won't complete before some SDK operations like serializing or making requests to Sentry are also finished. So this PR introduces non-blocking event sending functionality to the SDK.The functionality works like this:
Sentry::BackgroundWorkerwill be initialized too.Client#capture_event, instead of sending it directly withClient#send_event, we'll let the worker do it.Client#send_event.About Sentry::BackgroundWorker
config.asyncset, the worker won't initialize a thread pool and won't be used either.Sentry.initcall.New Configuration Option -
background_worker_threadsThis change also introduces a new
background_worker_threadsconfig option. It allows users to decide how many threads should the worker hold. By default, the value will be the number of the processors the user's machine has. For example, if the user's machine has 4 processors, the value would be 4.Of course, users can always override the value to fit their use cases, like
Users can also disable this new non-blocking behaviour by giving a
0value:closes #1130