Skip to content

Separate rack integration#1138

Merged
st0012 merged 5 commits intomasterfrom
separate-rack-integration
Dec 16, 2020
Merged

Separate rack integration#1138
st0012 merged 5 commits intomasterfrom
separate-rack-integration

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Dec 11, 2020

Rack integration should be optional. This PR makes sure non-Rack applications can still use this SDK without any issue.

closes #1136

@st0012 st0012 added this to the 4.0.1 milestone Dec 11, 2020
@st0012 st0012 self-assigned this Dec 11, 2020
@st0012 st0012 force-pushed the separate-rack-integration branch 3 times, most recently from 499c456 to ff977f2 Compare December 11, 2020 14:59
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 11, 2020

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.19%. Comparing base (34519d6) to head (4104b07).
⚠️ Report is 1261 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1138      +/-   ##
==========================================
+ Coverage   97.74%   98.19%   +0.44%     
==========================================
  Files         187       93      -94     
  Lines        7857     4042    -3815     
==========================================
- Hits         7680     3969    -3711     
+ Misses        177       73     -104     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@st0012 st0012 force-pushed the separate-rack-integration branch from ff977f2 to 51e19bf Compare December 11, 2020 15:02
@st0012 st0012 modified the milestones: 4.0.1, 4.0.2 Dec 11, 2020
@st0012 st0012 force-pushed the separate-rack-integration branch from 51e19bf to 9810785 Compare December 16, 2020 08:40
@st0012 st0012 modified the milestones: 4.0.2, 4.1.0 Dec 16, 2020
@st0012 st0012 force-pushed the separate-rack-integration branch from 9810785 to 072226b Compare December 16, 2020 08:43
@st0012 st0012 force-pushed the separate-rack-integration branch from 072226b to 9dd946e Compare December 16, 2020 08:45
@st0012 st0012 merged commit 87c03f0 into master Dec 16, 2020
@st0012 st0012 deleted the separate-rack-integration branch December 16, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LoadError when using sentry-ruby in a non-rack environment

2 participants