Skip to content

Interface improvements#1123

Merged
st0012 merged 6 commits intomasterfrom
interface-improvements
Dec 3, 2020
Merged

Interface improvements#1123
st0012 merged 6 commits intomasterfrom
interface-improvements

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Dec 3, 2020

This PR addresses the feedback in this comment (except for the should_capture one)

@st0012 st0012 added this to the 4.0.0 milestone Dec 3, 2020
@st0012 st0012 requested a review from HazAT December 3, 2020 04:39
@st0012 st0012 self-assigned this Dec 3, 2020
@st0012 st0012 force-pushed the interface-improvements branch from 67c80fa to abe3b5c Compare December 3, 2020 04:44
@st0012 st0012 mentioned this pull request Dec 3, 2020
Closed
7 tasks
HazAT
HazAT approved these changes Dec 3, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, otherwise lgtm

sentry-sidekiq/spec/sentry/sidekiq_spec.rb
Sentry.breadcrumbs.record do |crumb|
crumb.message = "I'm very sad!"
end
crumb = Sentry::Breadcrumb.new(message: "I'm very sad!")
Copy link
Copy Markdown
Member

@HazAT HazAT Dec 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

@st0012 st0012 force-pushed the interface-improvements branch from abe3b5c to da3a619 Compare December 3, 2020 08:59
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 3, 2020 •
edited
Loading

Codecov Report

Merging #1123 (da3a619) into master (8b6f640) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1123      +/-   ##
==========================================
+ Coverage   98.24%   98.25%   +0.01%     
==========================================
  Files         149      149              
  Lines        6423     6412      -11     
==========================================
- Hits         6310     6300      -10     
+ Misses        113      112       -1
Impacted Files Coverage Δ
...b/sentry/rails/breadcrumb/active_support_logger.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry-ruby.rb 98.50% <100.00%> (+0.06%) ⬆️
sentry-ruby/lib/sentry/breadcrumb.rb 92.85% <100.00%> (ø)
sentry-ruby/lib/sentry/breadcrumb/sentry_logger.rb 100.00% <100.00%> (+2.77%) ⬆️
sentry-ruby/lib/sentry/breadcrumb_buffer.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/client.rb 95.34% <100.00%> (ø)
sentry-ruby/lib/sentry/configuration.rb 96.02% <100.00%> (-0.24%) ⬇️
sentry-ruby/lib/sentry/event.rb 98.93% <100.00%> (ø)
...-ruby/spec/sentry/breadcrumb/sentry_logger_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/configuration_spec.rb 98.52% <100.00%> (-0.09%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b6f640...da3a619. Read the comment docs.

@st0012 st0012 merged commit 0ec641d into master Dec 3, 2020
@st0012 st0012 deleted the interface-improvements branch December 3, 2020 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HazAT HazAT HazAT approved these changes

Assignees

@st0012 st0012

Labels

None yet

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@st0012 @codecov-io @HazAT