Skip to content

Fix async#1098

Merged
st0012 merged 3 commits intomasterfrom
fix-async
Nov 6, 2020
Merged

Fix async#1098
st0012 merged 3 commits intomasterfrom
fix-async

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Nov 6, 2020

No description provided.

It should be handled in Client instead of Transport#send_event, otherwise it'll
likely to trigger an infitie loop.
@st0012 st0012 added the bug fix label Nov 6, 2020
@st0012 st0012 added this to the 4.0.0 milestone Nov 6, 2020
@st0012 st0012 self-assigned this Nov 6, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 6, 2020

Codecov Report

❌ Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.50%. Comparing base (b21a920) to head (54091bb).
⚠️ Report is 1291 commits behind head on master.

Files with missing lines Patch % Lines
sentry-ruby/lib/sentry.rb 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1098      +/-   ##
==========================================
- Coverage   97.83%   97.50%   -0.33%     
==========================================
  Files         135       76      -59     
  Lines        5730     3212    -2518     
==========================================
- Hits         5606     3132    -2474     
+ Misses        124       80      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@st0012 st0012 merged commit 8b4191e into master Nov 6, 2020
@st0012 st0012 deleted the fix-async branch November 6, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants