Allow passing custom scope to Hub#capture* helpers#1086
Merged
Conversation
9d5a033 to
e5bc1df
Compare
Codecov Report
@@ Coverage Diff @@
## master #1086 +/- ##
==========================================
+ Coverage 98.43% 98.81% +0.37%
==========================================
Files 91 32 -59
Lines 4292 1862 -2430
==========================================
- Hits 4225 1840 -2385
+ Misses 67 22 -45 Continue to review full report at Codecov.
|
HazAT
requested changes
Nov 4, 2020
Member
HazAT
left a comment
There was a problem hiding this comment.
Also I think we can de-duplicate the tests a bit.
captureException, captureMessage and captureEvent all have the same tests with content.
Maybe we can switch it so captureException and captureMessage only test that they accept all parameter, where captureEvent really tests all the possible combinations.
HazAT
approved these changes
Nov 6, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements and closes #1061. See
sentry-ruby/spec/sentry/hub_spec.rb's#capture_*specs for examples