Merge f3794a8 into 1a47151

st0012 · web-flow · commit ca0cc59e553c · 2021-08-08T16:24:37.000Z
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,5 @@
+- Add severity as `sentry_logger`'s breadcrumb hint [#1527](https://github.com/getsentry/sentry-ruby/pull/1527)
+
 ## 4.6.4
 
 - Extend Rake with a more elegant and reliable way [#1517](https://github.com/getsentry/sentry-ruby/pull/1517)
diff --git a/sentry-ruby/lib/sentry-ruby.rb b/sentry-ruby/lib/sentry-ruby.rb
@@ -100,8 +100,8 @@ def get_main_hub
     end
 
     # Takes an instance of Sentry::Breadcrumb and stores it to the current active scope.
-    def add_breadcrumb(breadcrumb)
-      get_current_hub&.add_breadcrumb(breadcrumb)
+    def add_breadcrumb(breadcrumb, **options)
+      get_current_hub&.add_breadcrumb(breadcrumb, **options)
     end
 
     # Returns the current active hub.
diff --git a/sentry-ruby/lib/sentry/breadcrumb/sentry_logger.rb b/sentry-ruby/lib/sentry/breadcrumb/sentry_logger.rb
@@ -67,7 +67,7 @@ def add_breadcrumb(severity, message = nil, progname = nil)
             type: severity >= 3 ? "error" : level
           )
 
-          Sentry.add_breadcrumb(crumb)
+          Sentry.add_breadcrumb(crumb, hint: { severity: severity })
         end
       end
 
diff --git a/sentry-ruby/spec/sentry/breadcrumb/sentry_logger_spec.rb b/sentry-ruby/spec/sentry/breadcrumb/sentry_logger_spec.rb
@@ -19,7 +19,7 @@
     expect(breadcrumb.level).to eq("info")
     expect(breadcrumb.message).to eq("foo")
   end
-  
+
   it "records non-String message" do
     logger.info(200)
     expect(breadcrumbs.peek.message).to eq("200")
@@ -35,6 +35,19 @@
     expect(breadcrumbs.peek).to be_nil
   end
 
+  it "passes severity as a hint" do
+    hint = nil
+    Sentry.configuration.before_breadcrumb = lambda do |breadcrumb, h|
+      hint = h
+      breadcrumb
+    end
+
+    logger.info("foo")
+
+    expect(breadcrumbs.peek.message).to eq("foo")
+    expect(hint[:severity]).to eq(1)
+  end
+
   describe "category assignment" do
     it "assigned 'logger' by default" do
       logger.info("foo")

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	+- Add severity as `sentry_logger`'s breadcrumb hint [#1527](https://github.com/getsentry/sentry-ruby/pull/1527)
	`2`	`+`
`1`	`3`	`## 4.6.4`
`2`	`4`
`3`	`5`	`- Extend Rake with a more elegant and reliable way [#1517](https://github.com/getsentry/sentry-ruby/pull/1517)`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ def add_breadcrumb(severity, message = nil, progname = nil)`
`67`	`67`	`type: severity >= 3 ? "error" : level`
`68`	`68`	`)`
`69`	`69`
`70`		`- Sentry.add_breadcrumb(crumb)`
	`70`	`+ Sentry.add_breadcrumb(crumb, hint: { severity: severity })`
`71`	`71`	`end`
`72`	`72`	`end`
`73`	`73`