Simple update demonstrating how the code may be written to handle nested childs

pbernery · pbernery · commit b30d84afb366 · 2022-02-11T17:02:08.000+01:00
diff --git a/sentry-rails/lib/sentry/rails/tracing/abstract_subscriber.rb b/sentry-rails/lib/sentry/rails/tracing/abstract_subscriber.rb
@@ -41,14 +41,18 @@ def record_on_current_span(duration:, **options)
             return unless options[:start_timestamp]
 
             scope = Sentry.get_current_scope
-            transaction = scope.get_transaction
-            return unless transaction && transaction.sampled
+            current_span = scope.get_span
+            return unless current_span && current_span.sampled
+
+            span = current_span.start_child(**options)
+            Sentry.get_current_scope.set_span(span)
 
-            span = transaction.start_child(**options)
             # duration in ActiveSupport is computed in millisecond
             # so we need to covert it as second before calculating the timestamp
             span.set_timestamp(span.start_timestamp + duration / 1000)
             yield(span) if block_given?
+
+            Sentry.get_current_scope.set_span(current_span)
           end
         end
       end
