Improve Backtrace's specs

st0012 · st0012 · commit 925bf251528f · 2021-01-10T12:50:44.000+08:00
diff --git a/sentry-ruby/spec/sentry/backtrace_spec.rb b/sentry-ruby/spec/sentry/backtrace_spec.rb
@@ -1,9 +1,43 @@
 require 'spec_helper'
 
 RSpec.describe Sentry::Backtrace do
-  let(:configuration) { Sentry::Configuration.new }
+  let(:fixture_root) { File.join(Dir.pwd, "spec", "support") }
+  let(:fixture_file) { File.join(fixture_root, "stacktrace_test_fixture.rb") }
+  let(:configuration) do
+    Sentry::Configuration.new.tap do |config|
+      config.project_root = fixture_root
+    end
+  end
+
   let(:backtrace) do
-    Sentry::Backtrace.parse(Thread.current.backtrace, configuration.project_root, configuration.app_dirs_pattern)
+    [
+      "#{fixture_file}:6:in `bar'",
+      "#{fixture_file}:2:in `foo'"
+    ]
+  end
+
+  let(:parsed_backtrace) do
+    described_class.parse(backtrace, fixture_root, configuration.app_dirs_pattern)
+  end
+
+  describe ".parse" do
+    it "returns an array of StacktraceInterface::Frames with correct information" do
+      lines = parsed_backtrace.lines.reverse
+
+      expect(lines.count).to eq(2)
+
+      first_line = lines.first
+
+      expect(first_line.file).to match(/stacktrace_test_fixture.rb/)
+      expect(first_line.method).to eq("foo")
+      expect(first_line.number).to eq(2)
+
+      second_line = lines.last
+
+      expect(second_line.file).to match(/stacktrace_test_fixture.rb/)
+      expect(second_line.method).to eq("bar")
+      expect(second_line.number).to eq(6)
+    end
   end
 
   it "calls backtrace_cleanup_callback if it's present in the configuration" do
@@ -18,19 +52,19 @@
   end
 
   it "#lines" do
-    expect(backtrace.lines.first).to be_a(Sentry::Backtrace::Line)
+    expect(parsed_backtrace.lines.first).to be_a(Sentry::Backtrace::Line)
   end
 
   it "#inspect" do
-    expect(backtrace.inspect).to match(/Backtrace: .*>$/)
+    expect(parsed_backtrace.inspect).to match(/Backtrace: .*>$/)
   end
 
   it "#to_s" do
-    expect(backtrace.to_s).to match(/backtrace_spec.rb:\d/)
+    expect(parsed_backtrace.to_s).to match(/stacktrace_test_fixture.rb:\d/)
   end
 
   it "==" do
-    backtrace2 = Sentry::Backtrace.new(backtrace.lines)
-    expect(backtrace).to be == backtrace2
+    backtrace2 = Sentry::Backtrace.new(parsed_backtrace.lines)
+    expect(parsed_backtrace).to be == backtrace2
   end
 end
