Test sentry rails integration separately (#1321)

st0012 · web-flow · commit 80aedecc8953 · 2021-03-10T14:37:14.000+08:00
* Test sentry-rails integraion in a separate process

Most of the sentry-sidekiq tests should be run without sentry-rails and
rails. And since there's no easy way to unload those gems in a RSpec
process, we should use 2 processes to test them separately.

* Use make test for running sentry-sidekiq's specs on CI
diff --git a/.github/workflows/sentry_sidekiq_test.yml b/.github/workflows/sentry_sidekiq_test.yml
@@ -40,4 +40,4 @@ jobs:
     - name: Run specs
       run: |
         bundle install --jobs 4 --retry 3
-        bundle exec rake
+        make test
diff --git a/sentry-sidekiq/Makefile b/sentry-sidekiq/Makefile
@@ -1,3 +1,7 @@
 build:
 	bundle install
 	gem build sentry-sidekiq.gemspec
+
+test:
+	bundle exec rspec
+	WITH_SENTRY_RAILS=1 bundle exec rspec spec/sentry/rails_spec.rb
diff --git a/sentry-sidekiq/spec/sentry/rails_spec.rb b/sentry-sidekiq/spec/sentry/rails_spec.rb
@@ -1,3 +1,5 @@
+return unless ENV["WITH_SENTRY_RAILS"]
+
 require "rails"
 require "sentry-rails"
 require "spec_helper"

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+return unless ENV["WITH_SENTRY_RAILS"]`
	`2`	`+`
`1`	`3`	`require "rails"`
`2`	`4`	`require "sentry-rails"`
`3`	`5`	`require "spec_helper"`