This repository was archived by the owner on Aug 30, 2023. It is now read-only.
Conversation
size-limit report 📦
|
Member
Author
|
Just noticed that there are more type errors in the tests. Will take a look tomorrow and mark this PR as ready to review afterwards. |
mydea
approved these changes
Nov 23, 2022
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ESLint config from the JS SDK monorepo by tmp-adding the
@sentry-internal/eslint-config-sdkas a dev dependency. Furthermore, this PR replaces the.eslintrc.jswith the root.eslintrcof the monorepo and adds a few changes to it. Overall, our ESLint config should right now conform with the monorepo's, albeit with a few temporarily added rule exceptions.I mostly deactivated rules that were complicated to apply right now or required deeper understanding of the code base. I applied auto-fixable changes and applied some quick and easy rules manually afterwards. Mostly stuff like return values or missing type declarations.
Going forward, once we migrated to the monorepo, we have to:
eslintrc.jsand discard the rest of that fileThe first commit contains the config changes, the second one the resulting code changes. We'll merge this PR without squashing to preserve both steps to update old PRs/branches more easily.
ref #311