fix: Add frame data to all spans created through API #5420

antonis · 2025-12-02T14:02:20Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

Based on #5419 to avoid any conflicts and test as a whole

📜 Description

Add frame data to all spans created through API

💡 Motivation and Context

Fixes #4933

💚 How did you test it?

CI, Manual

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

antonis · 2025-12-02T14:03:04Z

@sentry review

packages/core/src/js/tracing/integrations/nativeFrames.ts

github-actions · 2025-12-02T14:42:47Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	495.50 ms	543.00 ms	47.50 ms
Size	43.75 MiB	48.05 MiB	4.30 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`88890fe`+dirty	350.94 ms	365.74 ms	14.80 ms
`2104bb9`+dirty	410.71 ms	461.52 ms	50.81 ms
`266bc7e`+dirty	485.02 ms	551.94 ms	66.92 ms
`1d62dde`+dirty	409.00 ms	453.90 ms	44.90 ms
`526494a`+dirty	422.80 ms	438.90 ms	16.10 ms
`6416d6c`+dirty	407.30 ms	422.00 ms	14.70 ms
`e07935d`+dirty	448.82 ms	489.10 ms	40.29 ms
`fa7bb7e`+dirty	350.37 ms	377.02 ms	26.65 ms
`07808fb`+dirty	419.10 ms	419.08 ms	-0.02 ms
`c9e95bd`	428.04 ms	458.70 ms	30.65 ms

App size

Revision	Plain	With Sentry	Diff
`88890fe`+dirty	17.75 MiB	19.71 MiB	1.96 MiB
`2104bb9`+dirty	17.75 MiB	19.74 MiB	1.99 MiB
`266bc7e`+dirty	43.75 MiB	47.99 MiB	4.24 MiB
`1d62dde`+dirty	17.75 MiB	19.74 MiB	2.00 MiB
`526494a`+dirty	43.75 MiB	47.99 MiB	4.24 MiB
`6416d6c`+dirty	43.75 MiB	48.05 MiB	4.30 MiB
`e07935d`+dirty	43.75 MiB	47.99 MiB	4.24 MiB
`fa7bb7e`+dirty	17.75 MiB	19.75 MiB	2.00 MiB
`07808fb`+dirty	17.75 MiB	19.70 MiB	1.95 MiB
`c9e95bd`	17.75 MiB	19.68 MiB	1.93 MiB

Previous results on branch: antonis/manual-frames

Startup times

Revision	Plain	With Sentry	Diff
`cc9dfbd`+dirty	406.59 ms	421.66 ms	15.07 ms
`82143bd`+dirty	432.80 ms	452.60 ms	19.80 ms

App size

Revision	Plain	With Sentry	Diff
`cc9dfbd`+dirty	43.75 MiB	48.05 MiB	4.30 MiB
`82143bd`+dirty	43.75 MiB	48.05 MiB	4.30 MiB

github-actions · 2025-12-02T14:46:34Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	366.55 ms	390.04 ms	23.49 ms
Size	43.94 MiB	48.88 MiB	4.94 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`c4e097a`+dirty	382.43 ms	443.77 ms	61.34 ms
`7480abe`+dirty	363.80 ms	431.34 ms	67.54 ms
`266bc7e`+dirty	378.00 ms	392.81 ms	14.81 ms
`eb07ba3`+dirty	419.49 ms	482.12 ms	62.63 ms
`526494a`+dirty	361.10 ms	410.84 ms	49.74 ms
`1d62dde`+dirty	366.59 ms	408.80 ms	42.21 ms
`b3b5b0d`+dirty	361.42 ms	403.90 ms	42.48 ms
`6416d6c`+dirty	469.16 ms	508.22 ms	39.06 ms
`e07935d`+dirty	380.10 ms	377.48 ms	-2.62 ms
`fa7bb7e`+dirty	285.22 ms	323.44 ms	38.22 ms

App size

Revision	Plain	With Sentry	Diff
`c4e097a`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`7480abe`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`266bc7e`+dirty	43.94 MiB	48.82 MiB	4.88 MiB
`eb07ba3`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`526494a`+dirty	43.94 MiB	48.82 MiB	4.88 MiB
`1d62dde`+dirty	7.15 MiB	8.46 MiB	1.31 MiB
`b3b5b0d`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`6416d6c`+dirty	43.94 MiB	48.88 MiB	4.94 MiB
`e07935d`+dirty	43.94 MiB	48.82 MiB	4.88 MiB
`fa7bb7e`+dirty	7.15 MiB	8.46 MiB	1.31 MiB

Previous results on branch: antonis/manual-frames

Startup times

Revision	Plain	With Sentry	Diff
`cc9dfbd`+dirty	361.00 ms	384.16 ms	23.16 ms
`82143bd`+dirty	439.94 ms	459.74 ms	19.80 ms

App size

Revision	Plain	With Sentry	Diff
`cc9dfbd`+dirty	43.94 MiB	48.88 MiB	4.94 MiB
`82143bd`+dirty	43.94 MiB	48.88 MiB	4.94 MiB

github-actions · 2025-12-02T14:50:42Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1215.57 ms	1214.93 ms	-0.64 ms
Size	3.41 MiB	4.60 MiB	1.18 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d861c16`+dirty	1231.94 ms	1242.32 ms	10.38 ms
`c94a927`+dirty	1227.14 ms	1239.64 ms	12.50 ms
`ea3e26e`+dirty	1229.13 ms	1228.46 ms	-0.67 ms
`23080e5`+dirty	1216.02 ms	1224.94 ms	8.91 ms
`170d5ea`+dirty	1219.27 ms	1231.90 ms	12.63 ms
`2adbd1e`+dirty	1207.51 ms	1218.98 ms	11.47 ms
`ee69ed5`+dirty	1206.79 ms	1213.98 ms	7.19 ms
`c4e097a`+dirty	1229.09 ms	1242.61 ms	13.53 ms
`161947d`+dirty	1203.43 ms	1217.00 ms	13.57 ms
`652f785`+dirty	1219.66 ms	1223.62 ms	3.96 ms

App size

Revision	Plain	With Sentry	Diff
`d861c16`+dirty	2.63 MiB	4.00 MiB	1.36 MiB
`c94a927`+dirty	2.63 MiB	3.99 MiB	1.36 MiB
`ea3e26e`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`23080e5`+dirty	2.63 MiB	3.91 MiB	1.28 MiB
`170d5ea`+dirty	2.63 MiB	3.98 MiB	1.35 MiB
`2adbd1e`+dirty	2.63 MiB	4.00 MiB	1.36 MiB
`ee69ed5`+dirty	3.41 MiB	4.59 MiB	1.18 MiB
`c4e097a`+dirty	2.63 MiB	3.87 MiB	1.24 MiB
`161947d`+dirty	2.63 MiB	3.99 MiB	1.36 MiB
`652f785`+dirty	3.41 MiB	4.57 MiB	1.16 MiB

Previous results on branch: antonis/manual-frames

Startup times

Revision	Plain	With Sentry	Diff
`82143bd`+dirty	1214.28 ms	1212.96 ms	-1.32 ms
`cc9dfbd`+dirty	1214.30 ms	1217.12 ms	2.83 ms

App size

Revision	Plain	With Sentry	Diff
`82143bd`+dirty	3.41 MiB	4.60 MiB	1.18 MiB
`cc9dfbd`+dirty	3.41 MiB	4.60 MiB	1.18 MiB

github-actions · 2025-12-02T14:51:23Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1210.91 ms	1208.94 ms	-1.98 ms
Size	3.41 MiB	4.60 MiB	1.18 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d861c16`+dirty	1226.00 ms	1223.35 ms	-2.65 ms
`c94a927`+dirty	1211.33 ms	1223.31 ms	11.97 ms
`ea3e26e`+dirty	1216.61 ms	1214.15 ms	-2.47 ms
`23080e5`+dirty	1221.39 ms	1222.08 ms	0.70 ms
`170d5ea`+dirty	1233.96 ms	1242.54 ms	8.58 ms
`2adbd1e`+dirty	1220.65 ms	1230.20 ms	9.56 ms
`ee69ed5`+dirty	1212.78 ms	1214.91 ms	2.13 ms
`c4e097a`+dirty	1231.35 ms	1246.91 ms	15.56 ms
`161947d`+dirty	1203.45 ms	1217.83 ms	14.38 ms
`652f785`+dirty	1216.42 ms	1212.21 ms	-4.21 ms

App size

Revision	Plain	With Sentry	Diff
`d861c16`+dirty	3.19 MiB	4.56 MiB	1.38 MiB
`c94a927`+dirty	3.19 MiB	4.56 MiB	1.37 MiB
`ea3e26e`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`23080e5`+dirty	3.19 MiB	4.48 MiB	1.29 MiB
`170d5ea`+dirty	3.19 MiB	4.55 MiB	1.36 MiB
`2adbd1e`+dirty	3.19 MiB	4.56 MiB	1.38 MiB
`ee69ed5`+dirty	3.41 MiB	4.59 MiB	1.18 MiB
`c4e097a`+dirty	3.19 MiB	4.44 MiB	1.25 MiB
`161947d`+dirty	3.19 MiB	4.56 MiB	1.37 MiB
`652f785`+dirty	3.41 MiB	4.57 MiB	1.16 MiB

Previous results on branch: antonis/manual-frames

Startup times

Revision	Plain	With Sentry	Diff
`82143bd`+dirty	1216.04 ms	1216.39 ms	0.34 ms
`cc9dfbd`+dirty	1234.32 ms	1232.44 ms	-1.88 ms

App size

Revision	Plain	With Sentry	Diff
`82143bd`+dirty	3.41 MiB	4.60 MiB	1.18 MiB
`cc9dfbd`+dirty	3.41 MiB	4.60 MiB	1.18 MiB

lucas-zimerman

fantastic! LGTM!

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>

lucas-zimerman · 2025-12-04T13:13:06Z

Lets wait for ttid-ttfd-frames to be merged and, then change the target to main before unblocking

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>

antonis added 8 commits December 2, 2025 13:24

fix(ttid/ttfd): Add frame data to ttid/ttfd spans

eca4db1

Update changelog

9dd9d14

Fix lint issues

eb5570c

Prevent memory leak

200da06

Fix test feedback

8ee1b7d

Seer review feedback

426494a

fix potential race condition

212daa6

fix: Add frame data to all spans created through API

e2bbe8b

sentry bot reviewed Dec 2, 2025

View reviewed changes

packages/core/src/js/tracing/integrations/nativeFrames.ts Show resolved Hide resolved

packages/core/src/js/tracing/integrations/nativeFrames.ts Show resolved Hide resolved

Add explanatory comments

88b6297

antonis added the ready-to-merge Triggers the full CI test suite label Dec 2, 2025

antonis marked this pull request as ready for review December 2, 2025 14:44

antonis requested review from alwx and lucas-zimerman as code owners December 2, 2025 14:44

lucas-zimerman approved these changes Dec 4, 2025

View reviewed changes

lucas-zimerman mentioned this pull request Dec 4, 2025

fix(ttid/ttfd): Add frame data to ttid/ttfd spans #5419

Merged

10 tasks

lucas-zimerman added the Blocked label Dec 4, 2025

antonis and others added 2 commits December 4, 2025 14:12

Imrove log readability

a129ee1

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>

Merge branch 'main' into antonis/ttid-ttfd-frames

7fc55c8

antonis and others added 3 commits December 4, 2025 14:15

Merge branch 'antonis/ttid-ttfd-frames' into antonis/manual-frames

432316e

Update log for redability

4cdcbe7

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>

Merge branch 'antonis/ttid-ttfd-frames' into antonis/manual-frames

66f2e0f

Base automatically changed from antonis/ttid-ttfd-frames to main December 4, 2025 14:12

Merge branch 'main' into antonis/manual-frames

8d4b95f

antonis removed the Blocked label Dec 4, 2025

antonis enabled auto-merge (squash) December 4, 2025 14:13

antonis merged commit 5414b4b into main Dec 4, 2025
71 checks passed

antonis deleted the antonis/manual-frames branch December 4, 2025 14:16

Uh oh!

fix: Add frame data to all spans created through API #5420

fix: Add frame data to all spans created through API #5420

Uh oh!

Conversation

antonis commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

antonis commented Dec 2, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/manual-frames

Startup times

App size

Uh oh!

github-actions bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/manual-frames

Startup times

App size

Uh oh!

github-actions bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/manual-frames

Startup times

App size

Uh oh!

github-actions bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/manual-frames

Startup times

App size

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

lucas-zimerman commented Dec 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

antonis commented Dec 2, 2025 •

edited

Loading

github-actions bot commented Dec 2, 2025 •

edited

Loading

github-actions bot commented Dec 2, 2025 •

edited

Loading

github-actions bot commented Dec 2, 2025 •

edited

Loading

github-actions bot commented Dec 2, 2025 •

edited

Loading