chore(ci): Add Maestro update script in the workflow #4777

antonis · 2025-04-24T09:14:52Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Adds Maestro update script in the workflow

💡 Motivation and Context

See #4761 (review)

💚 How did you test it?

Manual locally

~/git/sentry-react-native$ ./scripts/update-maestro.sh set-version 1.39.0
✅ Updated ./scripts/../.github/workflows/e2e.yml to MAESTRO_VERSION: '1.39.0'
✅ Updated ./scripts/../.github/workflows/sample-application.yml to MAESTRO_VERSION: '1.39.0'
~/git/sentry-react-native$ ./scripts/update-maestro.sh get-version       
1.39.0
~/git/sentry-react-native$ ./scripts/update-maestro.sh get-repo          
https://github.com/mobile-dev-inc/Maestro.git
~/git/sentry-react-native$ ./scripts/update-maestro.sh set-version 1.40.0
✅ Updated ./scripts/../.github/workflows/e2e.yml to MAESTRO_VERSION: '1.40.0'
✅ Updated ./scripts/../.github/workflows/sample-application.yml to MAESTRO_VERSION: '1.40.0'

CI with #4778

note that the v tag prefix has been removed after the test with 1385509
the changelog has also been removed with b13477d

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog

Copilot

Pull Request Overview

This PR enhances the CI workflow by adding a new Maestro update job.

Adds a "maestro" job that leverages Sentry's GitHub workflow updater to run the Maestro update script.
Configures the job with the required parameters and secrets for version updates.

Files not reviewed (1)

scripts/update-maestro.sh: Language not supported

github-actions · 2025-04-24T09:30:49Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	441.61 ms	425.61 ms	-16.00 ms
Size	17.75 MiB	20.13 MiB	2.38 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`a0b0298`	427.50 ms	428.10 ms	0.60 ms
`e73d82f`	475.82 ms	506.55 ms	30.73 ms
`0eacc98`	431.88 ms	454.56 ms	22.68 ms
`2de79dc`	435.31 ms	416.96 ms	-18.35 ms
`9282172`	486.12 ms	467.70 ms	-18.42 ms
`a18210a`	455.15 ms	530.29 ms	75.15 ms
`24cb2a4`	451.04 ms	446.07 ms	-4.98 ms
`700cbf4`	425.56 ms	436.26 ms	10.70 ms
`5dff5ee`	462.32 ms	456.26 ms	-6.06 ms
`75774ea`	454.16 ms	467.80 ms	13.64 ms

App size

Revision	Plain	With Sentry	Diff
`a0b0298`	17.75 MiB	20.12 MiB	2.37 MiB
`e73d82f`	17.73 MiB	20.07 MiB	2.33 MiB
`0eacc98`	17.75 MiB	20.11 MiB	2.37 MiB
`2de79dc`	17.75 MiB	20.13 MiB	2.38 MiB
`9282172`	17.74 MiB	20.09 MiB	2.35 MiB
`a18210a`	17.75 MiB	20.11 MiB	2.36 MiB
`24cb2a4`	17.75 MiB	20.11 MiB	2.36 MiB
`700cbf4`	17.73 MiB	20.07 MiB	2.33 MiB
`5dff5ee`	17.75 MiB	20.11 MiB	2.36 MiB
`75774ea`	17.74 MiB	20.08 MiB	2.35 MiB

Previous results on branch: antonis/chore-maestro-bump-script

Startup times

Revision	Plain	With Sentry	Diff
`a647eff`	455.58 ms	435.78 ms	-19.80 ms

App size

Revision	Plain	With Sentry	Diff
`a647eff`	17.75 MiB	20.13 MiB	2.38 MiB

antonis · 2025-04-24T09:51:11Z

.github/workflows/update-deps.yml

+    with:
+      path: scripts/update-maestro.sh
+      name: Maestro
+      pattern: '^v[0-9.]+$' # only match non-preview versions


The Maestro version tags are similar with RN starting with v. A potential issue is that this might not be used consistently (e.g. v0.2.5 🤔) and there are also more than one tags on the release (e.g. v1.40.0 and cli-1.40.0). Looking at the dependency updater script I think this is the best approach for now.

Thanks, for the details, let's see how will work out.

This reverts commit d21e375.

This reverts commit 7281d0d.

github-actions · 2025-04-24T11:10:41Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1228.35 ms	1236.41 ms	8.05 ms
Size	2.63 MiB	3.78 MiB	1.15 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`b8ff156`+dirty	1236.51 ms	1234.53 ms	-1.98 ms
`40c35c5`+dirty	1211.31 ms	1217.71 ms	6.40 ms
`ae7b03d`+dirty	1221.19 ms	1224.69 ms	3.50 ms
`5fe8312`+dirty	1222.06 ms	1220.56 ms	-1.51 ms
`3f05680`+dirty	1229.37 ms	1235.04 ms	5.68 ms
`d197b5c`+dirty	1217.61 ms	1242.66 ms	25.05 ms
`34aba08`+dirty	1276.78 ms	1308.52 ms	31.74 ms
`457e29f`+dirty	1253.94 ms	1269.18 ms	15.24 ms
`f80e57e`+dirty	1217.29 ms	1230.61 ms	13.32 ms
`2dc8f22`+dirty	1224.88 ms	1212.40 ms	-12.47 ms

App size

Revision	Plain	With Sentry	Diff
`b8ff156`+dirty	2.36 MiB	3.11 MiB	759.80 KiB
`40c35c5`+dirty	2.63 MiB	3.70 MiB	1.07 MiB
`ae7b03d`+dirty	2.63 MiB	3.69 MiB	1.05 MiB
`5fe8312`+dirty	2.63 MiB	3.70 MiB	1.06 MiB
`3f05680`+dirty	2.63 MiB	3.74 MiB	1.11 MiB
`d197b5c`+dirty	2.36 MiB	2.82 MiB	462.86 KiB
`34aba08`+dirty	2.36 MiB	2.85 MiB	495.32 KiB
`457e29f`+dirty	2.36 MiB	2.87 MiB	520.67 KiB
`f80e57e`+dirty	2.63 MiB	3.78 MiB	1.14 MiB
`2dc8f22`+dirty	2.63 MiB	3.69 MiB	1.05 MiB

Previous results on branch: antonis/chore-maestro-bump-script

Startup times

Revision	Plain	With Sentry	Diff
`a647eff`+dirty	1215.82 ms	1222.29 ms	6.48 ms

App size

Revision	Plain	With Sentry	Diff
`a647eff`+dirty	2.63 MiB	3.78 MiB	1.14 MiB

github-actions · 2025-04-24T11:15:50Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1220.02 ms	1209.48 ms	-10.54 ms
Size	3.19 MiB	4.35 MiB	1.16 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`b8ff156`+dirty	1238.92 ms	1239.57 ms	0.66 ms
`40c35c5`+dirty	1223.90 ms	1217.19 ms	-6.71 ms
`ae7b03d`+dirty	1223.71 ms	1227.69 ms	3.98 ms
`5fe8312`+dirty	1235.07 ms	1220.41 ms	-14.66 ms
`3f05680`+dirty	1226.09 ms	1235.67 ms	9.59 ms
`d197b5c`+dirty	1234.80 ms	1249.20 ms	14.40 ms
`34aba08`+dirty	1268.58 ms	1276.80 ms	8.22 ms
`457e29f`+dirty	1256.71 ms	1258.50 ms	1.79 ms
`f80e57e`+dirty	1226.92 ms	1226.82 ms	-0.10 ms
`2dc8f22`+dirty	1215.43 ms	1206.68 ms	-8.75 ms

App size

Revision	Plain	With Sentry	Diff
`b8ff156`+dirty	2.92 MiB	3.67 MiB	772.38 KiB
`40c35c5`+dirty	3.19 MiB	4.27 MiB	1.08 MiB
`ae7b03d`+dirty	3.19 MiB	4.25 MiB	1.06 MiB
`5fe8312`+dirty	3.19 MiB	4.26 MiB	1.08 MiB
`3f05680`+dirty	3.19 MiB	4.31 MiB	1.12 MiB
`d197b5c`+dirty	2.92 MiB	3.37 MiB	464.41 KiB
`34aba08`+dirty	2.92 MiB	3.41 MiB	499.03 KiB
`457e29f`+dirty	2.92 MiB	3.43 MiB	524.75 KiB
`f80e57e`+dirty	3.19 MiB	4.34 MiB	1.16 MiB
`2dc8f22`+dirty	3.19 MiB	4.25 MiB	1.06 MiB

Previous results on branch: antonis/chore-maestro-bump-script

Startup times

Revision	Plain	With Sentry	Diff
`a647eff`+dirty	1215.15 ms	1216.06 ms	0.91 ms

App size

Revision	Plain	With Sentry	Diff
`a647eff`+dirty	3.19 MiB	4.35 MiB	1.16 MiB

… script"" This reverts commit b299da9.

github-actions · 2025-04-24T11:52:32Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	411.98 ms	423.34 ms	11.36 ms
Size	7.15 MiB	8.40 MiB	1.25 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`7301787`+dirty	462.28 ms	487.34 ms	25.06 ms
`00354a7`+dirty	426.55 ms	447.33 ms	20.78 ms
`1c65324`+dirty	381.10 ms	427.26 ms	46.16 ms
`42438c2`+dirty	652.82 ms	676.21 ms	23.39 ms
`0eacc98`+dirty	393.31 ms	445.21 ms	51.90 ms
`fc150fe`+dirty	409.55 ms	407.37 ms	-2.18 ms
`800171e`+dirty	432.15 ms	549.63 ms	117.48 ms
`2f9e699`+dirty	407.69 ms	398.20 ms	-9.49 ms
`4161236`+dirty	429.89 ms	498.74 ms	68.85 ms
`d997097`+dirty	404.23 ms	477.09 ms	72.87 ms

App size

Revision	Plain	With Sentry	Diff
`7301787`+dirty	7.15 MiB	8.40 MiB	1.24 MiB
`00354a7`+dirty	7.15 MiB	8.40 MiB	1.25 MiB
`1c65324`+dirty	7.15 MiB	8.22 MiB	1.07 MiB
`42438c2`+dirty	7.15 MiB	8.40 MiB	1.25 MiB
`0eacc98`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`fc150fe`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`800171e`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`2f9e699`+dirty	7.15 MiB	8.40 MiB	1.25 MiB
`4161236`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`d997097`+dirty	7.15 MiB	8.38 MiB	1.23 MiB

Previous results on branch: antonis/chore-maestro-bump-script

Startup times

Revision	Plain	With Sentry	Diff
`a647eff`+dirty	398.08 ms	382.63 ms	-15.46 ms

App size

Revision	Plain	With Sentry	Diff
`a647eff`+dirty	7.15 MiB	8.40 MiB	1.25 MiB

krystofwoldrich

LGTM 🚀 Thank you for adding the auto update!

antonis · 2025-05-06T08:02:41Z

The first bump using this change worked as expected 🎉

chore(ci): Add Maestro update script in the workflow

7395322

antonis requested a review from Copilot April 24, 2025 09:17

Copilot AI reviewed Apr 24, 2025

View reviewed changes

antonis mentioned this pull request Apr 24, 2025

chore(ci): Bump maestro version from 1.39.0 to 1.40.0 #4761

Merged

10 tasks

antonis marked this pull request as ready for review April 24, 2025 09:21

antonis requested review from krystofwoldrich and lucas-zimerman as code owners April 24, 2025 09:21

Only match non-preview versions

e650f6c

antonis commented Apr 24, 2025

View reviewed changes

antonis added 2 commits April 24, 2025 13:02

tmp: Add temp branch and a lower version to test the script

d21e375

Revert "tmp: Add temp branch and a lower version to test the script"

7281d0d

This reverts commit d21e375.

antonis mentioned this pull request Apr 24, 2025

chore(deps): update Maestro to - #4778

Closed

antonis marked this pull request as draft April 24, 2025 10:05

antonis added 3 commits April 24, 2025 13:38

skip changelog

b13477d

skip the tag prefix

1385509

Reapply "tmp: Add temp branch and a lower version to test the script"

b299da9

This reverts commit 7281d0d.

Revert "Reapply "tmp: Add temp branch and a lower version to test the…

060010c

… script"" This reverts commit b299da9.

antonis marked this pull request as ready for review April 24, 2025 11:23

krystofwoldrich approved these changes Apr 24, 2025

View reviewed changes

Merge branch 'main' into antonis/chore-maestro-bump-script

e0a7075

antonis enabled auto-merge (squash) April 24, 2025 12:23

antonis merged commit b0a7066 into main Apr 24, 2025
67 checks passed

antonis deleted the antonis/chore-maestro-bump-script branch April 24, 2025 12:25

Uh oh!

chore(ci): Add Maestro update script in the workflow #4777

chore(ci): Add Maestro update script in the workflow #4777

Uh oh!

Conversation

antonis commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

github-actions bot commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/chore-maestro-bump-script

Startup times

App size

Uh oh!

antonis Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

krystofwoldrich Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/chore-maestro-bump-script

Startup times

App size

Uh oh!

github-actions bot commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/chore-maestro-bump-script

Startup times

App size

Uh oh!

github-actions bot commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/chore-maestro-bump-script

Startup times

App size

Uh oh!

krystofwoldrich left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

antonis commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

antonis commented Apr 24, 2025 •

edited

Loading

github-actions bot commented Apr 24, 2025 •

edited

Loading

github-actions bot commented Apr 24, 2025 •

edited

Loading

github-actions bot commented Apr 24, 2025 •

edited

Loading

github-actions bot commented Apr 24, 2025 •

edited

Loading

antonis commented May 6, 2025 •

edited

Loading