feat(replay): Add Mask and Unmask Android implementation by krystofwoldrich · Pull Request #4265 · getsentry/sentry-react-native

krystofwoldrich · 2024-11-12T14:36:57Z

📢 Type of change

New feature

📜 Description

This PR adds new and legacy architecture impl of Mask and Unmask wrappers for custom redact of React Native components.

This is a follow up to feat(replay): Add SentryMask and SentryUnmask iOS components #4224
This PR needs sentry-android feat(replay): Add Mask/Unmask Containers for custom masking in hybrid SDKs sentry-java#3881
Legacy Arch Sample Replay
New Arch Sample Replay

Emulator	Replay

💚 How did you test it?

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

🔮 Next steps

…-redact-components

…act-components

…-redact-components

…droid

…mponents

…getsentry/sentry-react-native into kw/feat/replay-custom-redact-components

…eplay-custom-redact-android

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>

…eplay-custom-redact-android

github-actions · 2024-11-25T13:09:41Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1219.81 ms	1225.19 ms	5.37 ms
Size	2.36 MiB	3.10 MiB	759.68 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e2b64fe`+dirty	1232.22 ms	1255.20 ms	22.98 ms
`4cc5c27`+dirty	1211.45 ms	1214.60 ms	3.16 ms
`1c65324`+dirty	1235.17 ms	1235.08 ms	-0.09 ms
`cdf2f33`+dirty	1227.71 ms	1233.94 ms	6.22 ms
`e1ea4a8`+dirty	1233.49 ms	1237.71 ms	4.22 ms
`dadc233`+dirty	1223.20 ms	1236.88 ms	13.68 ms
`ed3d77e`+dirty	1214.61 ms	1205.83 ms	-8.78 ms
`2ec71da`+dirty	1225.85 ms	1231.57 ms	5.72 ms
`9cd0e9f`+dirty	1224.94 ms	1239.88 ms	14.94 ms
`0db0c72`+dirty	1275.02 ms	1285.84 ms	10.82 ms

App size

Revision	Plain	With Sentry	Diff
`e2b64fe`+dirty	2.36 MiB	2.85 MiB	495.80 KiB
`4cc5c27`+dirty	2.36 MiB	3.04 MiB	698.52 KiB
`1c65324`+dirty	2.36 MiB	3.04 MiB	698.64 KiB
`cdf2f33`+dirty	2.36 MiB	3.10 MiB	751.38 KiB
`e1ea4a8`+dirty	2.36 MiB	3.10 MiB	752.31 KiB
`dadc233`+dirty	2.36 MiB	2.84 MiB	486.85 KiB
`ed3d77e`+dirty	2.36 MiB	3.10 MiB	753.32 KiB
`2ec71da`+dirty	2.36 MiB	3.13 MiB	784.66 KiB
`9cd0e9f`+dirty	2.36 MiB	3.08 MiB	735.56 KiB
`0db0c72`+dirty	2.36 MiB	2.84 MiB	487.01 KiB

…eplay-custom-redact-android

krystofwoldrich · 2024-11-25T13:27:29Z

@antonis @lucas-zimerman This is a follow up to #4224, but this time for Android.

github-actions · 2024-11-25T13:35:29Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	497.05 ms	498.72 ms	1.67 ms
Size	17.74 MiB	20.08 MiB	2.35 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`8ae23a7`	526.83 ms	513.38 ms	-13.45 ms
`4297324`	536.61 ms	542.48 ms	5.87 ms
`dadc233`+dirty	333.78 ms	343.94 ms	10.16 ms
`c2a4e9b`	480.42 ms	485.60 ms	5.18 ms
`9433f35`	347.64 ms	356.22 ms	8.58 ms
`9a3ca65`+dirty	326.93 ms	330.14 ms	3.21 ms
`7bc4d75`	488.76 ms	473.28 ms	-15.48 ms
`0d3e677`	422.82 ms	411.90 ms	-10.92 ms
`80b2ce3`	385.02 ms	387.36 ms	2.34 ms
`1d86dd6`	405.14 ms	411.06 ms	5.92 ms

App size

Revision	Plain	With Sentry	Diff
`8ae23a7`	17.74 MiB	20.07 MiB	2.34 MiB
`4297324`	17.74 MiB	20.08 MiB	2.34 MiB
`dadc233`+dirty	17.73 MiB	19.75 MiB	2.02 MiB
`c2a4e9b`	17.73 MiB	20.06 MiB	2.33 MiB
`9433f35`	17.73 MiB	19.81 MiB	2.08 MiB
`9a3ca65`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`7bc4d75`	17.74 MiB	20.08 MiB	2.34 MiB
`0d3e677`	17.74 MiB	20.07 MiB	2.34 MiB
`80b2ce3`	17.73 MiB	19.75 MiB	2.02 MiB
`1d86dd6`	17.73 MiB	19.86 MiB	2.12 MiB

lucas-zimerman

Thank you for the PR! LGTM!

github-actions · 2024-11-25T13:45:41Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	412.20 ms	471.81 ms	59.61 ms
Size	7.15 MiB	8.37 MiB	1.22 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d43a46b`+dirty	417.65 ms	472.98 ms	55.33 ms
`4297324`+dirty	385.33 ms	435.68 ms	50.35 ms
`13f280b`+dirty	376.13 ms	406.41 ms	30.28 ms
`dadc233`+dirty	363.19 ms	370.37 ms	7.18 ms
`9a3ca65`+dirty	344.96 ms	358.92 ms	13.96 ms
`e2b64fe`+dirty	258.82 ms	304.26 ms	45.44 ms
`8ae23a7`+dirty	398.10 ms	411.48 ms	13.38 ms
`27ef4ee`+dirty	296.71 ms	351.00 ms	54.29 ms
`eb1e19f`+dirty	391.37 ms	418.27 ms	26.90 ms
`86d6d2c`+dirty	267.21 ms	325.24 ms	58.04 ms

App size

Revision	Plain	With Sentry	Diff
`d43a46b`+dirty	7.15 MiB	8.34 MiB	1.19 MiB
`4297324`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`13f280b`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`dadc233`+dirty	7.15 MiB	8.04 MiB	910.84 KiB
`9a3ca65`+dirty	7.15 MiB	8.09 MiB	962.83 KiB
`e2b64fe`+dirty	7.15 MiB	8.07 MiB	947.16 KiB
`8ae23a7`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`27ef4ee`+dirty	7.15 MiB	8.08 MiB	959.49 KiB
`eb1e19f`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`86d6d2c`+dirty	7.15 MiB	8.09 MiB	962.69 KiB

samples/react-native/src/App.tsx

packages/core/android/src/newarch/java/io/sentry/react/replay/RNSentryReplayUnmaskManager.java

antonis

LGTM 🚀

Added a questions/nitpick with https://github.com/getsentry/sentry-react-native/pull/4265/files#r1856782186

Krystof Woldrich and others added 30 commits October 31, 2024 17:13

feat(replay): Add SentryMask and SentryUnmask native components

0fc1b42

add clang-format

9933a86

apply the formatter

e17ac31

Merge remote-tracking branch 'origin/main' into kw/feat/replay-custom…

534cbce

…-redact-components

Merge remote-tracking branch 'origin/main' into kw/internal/clag-format

ef863a1

Merge branch 'kw/internal/clag-format' into kw/feat/replay-custom-red…

d317e1e

…act-components

fix clang format

eb9d2de

add native architecture masks for ios

cbf400a

Merge remote-tracking branch 'origin/main' into kw/feat/replay-custom…

be04dfc

…-redact-components

add js tests

77691bd

fix eslint changing the native props interface to type

45374be

Fix mask components for non uikit builds

0a127d2

add changelog

4f5b967

fix typo

eb64e8d

fix ts3.8 type check test

32c45e4

Merge branch 'kw/fix/type-check' into kw/feat/replay-custom-redact-an…

691f8f4

…droid

fix new arch build decoupled replay and replay mask

02bb913

fix missing react native types

5315bb2

Merge branch 'kw/fix/type-check' into kw/feat/replay-custom-redact-co…

f07f155

…mponents

Merge branch 'main' into kw/feat/replay-custom-redact-components

1b1c435

Update mask sample

cdd3da8

fix rn unmask class is added to unmask array

1170838

fix tests for custom classes

3a9e155

Update samples/react-native/src/App.tsx

c02d06c

update redact example

9fe9c24

fix changelog and macos sample

845c260

fix rnsentry impl

2edaeb0

Merge branch 'main' into kw/feat/replay-custom-redact-components

503c992

fix class names tests

4f88064

Merge branch 'kw/feat/replay-custom-redact-components' of github.com:…

ddffa75

…getsentry/sentry-react-native into kw/feat/replay-custom-redact-components

Krystof Woldrich and others added 9 commits November 22, 2024 18:51

Merge branch 'kw/feat/replay-custom-redact-components' into kw/feat/r…

fad832e

…eplay-custom-redact-android

fix changelog

eacc487

fix old RN builds, remove ts from shipped package

eb457fc

Merge branch '6.3.0-beta' into kw/feat/replay-custom-redact-components

5965c22

fix custom mask tests

b41d759

Merge branch 'kw/feat/replay-custom-redact-components' into kw/feat/r…

ab42222

…eplay-custom-redact-android

add native component registry access explanation

8eaa867

Apply suggestions from code review

4e18dc4

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>

Merge branch 'kw/feat/replay-custom-redact-components' into kw/feat/r…

aef7146

…eplay-custom-redact-android

Krystof Woldrich added 3 commits November 25, 2024 14:15

use deprecated ReactModuleInfo constructor

71664ae

fix lint

af13626

Merge branch 'kw/feat/replay-custom-redact-components' into kw/feat/r…

e77e2eb

…eplay-custom-redact-android

krystofwoldrich marked this pull request as ready for review November 25, 2024 13:26

krystofwoldrich requested review from antonis and lucas-zimerman as code owners November 25, 2024 13:26

lucas-zimerman approved these changes Nov 25, 2024

View reviewed changes

antonis reviewed Nov 25, 2024

View reviewed changes

samples/react-native/src/App.tsx Outdated Show resolved Hide resolved

remove unintentional sample text element

2189770

antonis reviewed Nov 25, 2024

View reviewed changes

packages/core/android/src/newarch/java/io/sentry/react/replay/RNSentryReplayUnmaskManager.java Outdated Show resolved Hide resolved

antonis approved these changes Nov 25, 2024

View reviewed changes

reuse class name from impl

3bcd455

Base automatically changed from kw/feat/replay-custom-redact-components to main November 25, 2024 16:44

Merge branch 'main' into kw/feat/replay-custom-redact-android

68f6282

krystofwoldrich merged commit 127cae6 into main Nov 25, 2024

krystofwoldrich deleted the kw/feat/replay-custom-redact-android branch November 25, 2024 16:51

alwx mentioned this pull request Aug 14, 2025

Implement TTID/TTFD as Turbo Modules #4705

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(replay): Add Mask and Unmask Android implementation#4265

feat(replay): Add Mask and Unmask Android implementation#4265
krystofwoldrich merged 57 commits intomainfrom
kw/feat/replay-custom-redact-android

krystofwoldrich commented Nov 12, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Nov 25, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Uh oh!

krystofwoldrich commented Nov 25, 2024

Uh oh!

github-actions bot commented Nov 25, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Uh oh!

lucas-zimerman left a comment

Uh oh!

github-actions bot commented Nov 25, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Uh oh!

Uh oh!

Uh oh!

antonis left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

krystofwoldrich commented Nov 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

krystofwoldrich commented Nov 25, 2024

Uh oh!

github-actions bot commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

Uh oh!

Uh oh!

antonis left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

krystofwoldrich commented Nov 12, 2024 •

edited

Loading

github-actions bot commented Nov 25, 2024 •

edited

Loading

github-actions bot commented Nov 25, 2024 •

edited

Loading

github-actions bot commented Nov 25, 2024 •

edited

Loading