Skip to content

fix(event): Message event includes current stack trace in threads#2694

Merged
krystofwoldrich merged 12 commits into5.0.0from
refactor-client-event-from
Dec 16, 2022
Merged

fix(event): Message event includes current stack trace in threads#2694
krystofwoldrich merged 12 commits into5.0.0from
refactor-client-event-from

Conversation

@krystofwoldrich
Copy link
Copy Markdown
Contributor

@krystofwoldrich krystofwoldrich commented Dec 13, 2022 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

By exporting event builder methods we could remove BrowserClient instance from RNClient.

By adding threads to event. We could patch RN SDK before this patch makes in to JS SDK v8.

💡 Motivation and Context

closes: #2461

💚 How did you test it?

unit tests and sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

krystofwoldrich
krystofwoldrich commented Dec 13, 2022
View reviewed changes
This was referenced Dec 13, 2022
Merged
Merged
@krystofwoldrich krystofwoldrich changed the title ref(client): Remove dep on BrowserClient fix(event): Message includes current stack trace in threads Dec 14, 2022
@krystofwoldrich krystofwoldrich changed the base branch from main to 5.0.0 December 14, 2022 09:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 14, 2022 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 344.96 ms 363.58 ms 18.62 ms
Size 17.73 MiB 19.95 MiB 2.22 MiB

Baseline results on branch: 5.0.0

Startup times

Revision Plain With Sentry Diff
b868b53+dirty 339.52 ms 369.84 ms 30.32 ms
d091239+dirty 425.61 ms 447.11 ms 21.50 ms

App size

Revision Plain With Sentry Diff
b868b53+dirty 17.73 MiB 19.95 MiB 2.22 MiB
d091239+dirty 17.73 MiB 19.95 MiB 2.22 MiB

@krystofwoldrich krystofwoldrich changed the title fix(event): Message includes current stack trace in threads fix(event): Message event includes current stack trace in threads Dec 14, 2022
@krystofwoldrich krystofwoldrich marked this pull request as ready for review December 14, 2022 11:15
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 14, 2022 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1268.27 ms 1280.54 ms 12.27 ms
Size 2.92 MiB 3.30 MiB 387.21 KiB

Baseline results on branch: 5.0.0

Startup times

Revision Plain With Sentry Diff
b868b53+dirty 1253.68 ms 1253.94 ms 0.26 ms
d091239+dirty 1261.62 ms 1275.80 ms 14.17 ms

App size

Revision Plain With Sentry Diff
b868b53+dirty 2.92 MiB 3.30 MiB 387.19 KiB
d091239+dirty 2.92 MiB 3.30 MiB 387.22 KiB

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 14, 2022 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 312.04 ms 337.94 ms 25.89 ms
Size 7.15 MiB 8.00 MiB 874.27 KiB

Baseline results on branch: 5.0.0

Startup times

Revision Plain With Sentry Diff
b868b53+dirty 321.42 ms 342.74 ms 21.32 ms
d091239+dirty 340.16 ms 366.42 ms 26.26 ms

App size

Revision Plain With Sentry Diff
b868b53+dirty 7.15 MiB 8.00 MiB 874.27 KiB
d091239+dirty 7.15 MiB 8.00 MiB 874.38 KiB

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 14, 2022 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1268.90 ms 1280.56 ms 11.66 ms
Size 2.36 MiB 2.74 MiB 384.65 KiB

Baseline results on branch: 5.0.0

Startup times

Revision Plain With Sentry Diff
b868b53+dirty 1274.90 ms 1305.68 ms 30.78 ms
d091239+dirty 1251.49 ms 1276.75 ms 25.26 ms

App size

Revision Plain With Sentry Diff
b868b53+dirty 2.36 MiB 2.74 MiB 384.64 KiB
d091239+dirty 2.36 MiB 2.74 MiB 384.64 KiB

@krystofwoldrich krystofwoldrich merged commit ad17b3e into 5.0.0 Dec 16, 2022
@krystofwoldrich krystofwoldrich deleted the refactor-client-event-from branch December 16, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad left review comments

@marandaneto marandaneto marandaneto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@krystofwoldrich @marandaneto @AbhiPrasad