fix(feedback): Guard against shake listener crashes and asymmetric lifecycle

antonis · claude · antonis · commit e7996b8efe39 · 2026-03-19T12:06:56.000+01:00
- Wrap stopShakeListener native calls in try/catch so exceptions from
  subscription.remove() or disableShakeDetection() never crash the app.
- Guard enableFeedbackOnShake so repeated calls don't overwrite
  _imperativeShakeListenerStarted with false, which would make
  disableFeedbackOnShake a permanent no-op.

Co-Authored-By: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/packages/core/src/js/feedback/FeedbackWidgetManager.tsx b/packages/core/src/js/feedback/FeedbackWidgetManager.tsx
@@ -137,7 +137,9 @@ let _imperativeShakeListenerStarted = false;
 
 const enableFeedbackOnShake = (): void => {
   lazyLoadAutoInjectFeedbackIntegration();
-  _imperativeShakeListenerStarted = startShakeListener(showFeedbackWidget);
+  if (!_imperativeShakeListenerStarted) {
+    _imperativeShakeListenerStarted = startShakeListener(showFeedbackWidget);
+  }
 };
 
 const disableFeedbackOnShake = (): void => {
diff --git a/packages/core/src/js/feedback/ShakeToReportBug.ts b/packages/core/src/js/feedback/ShakeToReportBug.ts
@@ -73,11 +73,19 @@ export function startShakeListener(
  */
 export function stopShakeListener(): void {
   if (_shakeSubscription) {
-    _shakeSubscription.remove();
+    try {
+      _shakeSubscription.remove();
+    } catch (e) {
+      debug.warn('Failed to remove shake subscription:', e);
+    }
     _shakeSubscription = null;
 
-    const nativeModule = getRNSentryModule() as { disableShakeDetection?: () => void } | undefined;
-    nativeModule?.disableShakeDetection?.();
+    try {
+      const nativeModule = getRNSentryModule() as { disableShakeDetection?: () => void } | undefined;
+      nativeModule?.disableShakeDetection?.();
+    } catch (e) {
+      debug.warn('Failed to disable native shake detection:', e);
+    }
   }
 }
 
