Skip to content

fix(starlette): Catch Jinja2Templates ImportError#5741

Merged
alexander-alderman-webb merged 2 commits intomasterfrom
webb/starlette/gate-jinja-template-import
Mar 23, 2026
Merged

fix(starlette): Catch Jinja2Templates ImportError#5741
alexander-alderman-webb merged 2 commits intomasterfrom
webb/starlette/gate-jinja-template-import

Conversation

@alexander-alderman-webb
Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb commented Mar 23, 2026

Description

Issues

Reminders

@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner March 23, 2026 07:53
@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2026 •
edited
Loading

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

New Features ✨

  • (asgi) Add option to disable suppressing chained exceptions by alexander-alderman-webb in #5714
  • (logging) Separate ignore lists for events/breadcrumbs and sentry logs by sl0thentr0py in #5698

Bug Fixes 🐛

Anthropic

  • Set exception info on streaming span when applicable by alexander-alderman-webb in #5683
  • Patch AsyncStream.close() and AsyncMessageStream.close() to finish spans by alexander-alderman-webb in #5675
  • Patch Stream.close() and MessageStream.close() to finish spans by alexander-alderman-webb in #5674

Other

  • (starlette) Catch Jinja2Templates ImportError by alexander-alderman-webb in #5741

Documentation 📚

  • Add note on AI PRs to CONTRIBUTING.md by sentrivana in #5696

Internal Changes 🔧

  • Add -latest alias for each integration test suite by sentrivana in #5706
  • Use date-based branch names for toxgen PRs by sentrivana in #5704
  • 🤖 Update test matrix with new releases (03/19) by github-actions in #5703
  • Add client report tests for span streaming by sentrivana in #5677

Other

  • Update CHANGELOG.md by sentrivana in #5685

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2026 •
edited
Loading

Codecov Results 📊

✅ 1850 passed | ⏭️ 170 skipped | Total: 2020 | Pass Rate: 91.58% | Execution Time: 3m 32s

📊 Comparison with Base Branch

Metric Change
Total Tests —
Passed Tests —
Failed Tests —
Skipped Tests —

✨ No test changes detected

All tests are passing successfully.

❌ Patch coverage is 0.00%. Project has 11960 uncovered lines.
✅ Project coverage is 41.32%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
starlette.py 5.29% ⚠️ 340 Missing
Coverage diff 
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    41.32%    41.32%        —%
==========================================
  Files          188       188         —
  Lines        20378     20381        +3
  Branches      7458      7458         —
==========================================
+ Hits          8421      8421         —
- Misses       11957     11960        +3
- Partials       442       442         —

Generated by Codecov Action

@alexander-alderman-webb alexander-alderman-webb merged commit b2b42df into master Mar 23, 2026
162 of 164 checks passed
@alexander-alderman-webb alexander-alderman-webb deleted the webb/starlette/gate-jinja-template-import branch March 23, 2026 09:49
@alexander-alderman-webb alexander-alderman-webb mentioned this pull request Mar 23, 2026
Closed
@sentrivana sentrivana mentioned this pull request Mar 24, 2026
Closed
@sentry-release-bot sentry-release-bot bot mentioned this pull request Mar 24, 2026
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexander-alderman-webb @sl0thentr0py