fix(LRUCache): copy using deepcopy, and ensure the get_all function always terminates#3861
Merged
antonpirker merged 1 commit intomasterfrom Dec 6, 2024
Merged
fix(LRUCache): copy using deepcopy, and ensure the get_all function always terminates#3861antonpirker merged 1 commit intomasterfrom
antonpirker merged 1 commit intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3861 +/- ##
==========================================
+ Coverage 79.91% 79.93% +0.02%
==========================================
Files 137 137
Lines 15401 15403 +2
Branches 2619 2620 +1
==========================================
+ Hits 12307 12312 +5
+ Misses 2221 2219 -2
+ Partials 873 872 -1
|
aliu39
approved these changes
Dec 5, 2024
Member
|
We found out the process will hang if you copy a LRUCache, then call get_all() on the original. It works as expected if you call get_all() on clones. Will add some coverage in FF tests for this case (fork a scope then read the flags on the original scope) |
Contributor
|
This has been released with version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@aliu39 discovered that under certain circumstances a process can get stuck in an infinite loop. Andrew fixed this by using
deepcopywhich prevents the infinite loop and fixes a bug where the LRU returns incorrect results. Additionally, I've added a terminating loop in case there are any future bugs we've missed.Closes: #3862
Out of precaution, we disabled flagpole evaluation tracking Sentry while we wait for this to be merged.