Bring all span data under pii control in rust_tracing integration#3778
Closed
antonpirker wants to merge 1 commit intomasterfrom
Closed
Bring all span data under pii control in rust_tracing integration#3778antonpirker wants to merge 1 commit intomasterfrom
antonpirker wants to merge 1 commit intomasterfrom
Conversation
❌ 132 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
matt-codecov
requested changes
Nov 14, 2024
Contributor
matt-codecov
left a comment
There was a problem hiding this comment.
could you rename send_sensitive_data to include_tracing_fields? i worry users will not know what we could possibly mean by "sensitive data" because this is mostly data they explicitly want tracing to record. include_tracing_fields is a more accurate name
Contributor
|
#3780 i implemented my name-change suggestion here. also moved the |
Contributor
Author
|
Closing in favor of #3780 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before only data that was set in
on_recordwas protected by our PII controls. Now also the span data that is add inon_new_spanis prtected by PII controls.Thank you for contributing to
sentry-python! Please add tests to validate your changes, and lint your code usingtox -e linters.Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.