fix: Fix breadcrumb timestamp casting and its tests#3546
Merged
sentrivana merged 27 commits intogetsentry:masterfrom Sep 23, 2024
BYK:byk/tests/timezones
Merged
fix: Fix breadcrumb timestamp casting and its tests#3546sentrivana merged 27 commits intogetsentry:masterfrom BYK:byk/tests/timezones
sentrivana merged 27 commits intogetsentry:masterfrom
BYK:byk/tests/timezones
Conversation
These tests were failing for me locally as the timestamps were without `tzinfo` and all were assumed UTC whereas my local timezone is BST at the moment. This patch fixes them by forcing things to have the UTC timezone.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #3546 +/- ##
=======================================
Coverage 84.49% 84.49%
=======================================
Files 133 133
Lines 13844 13855 +11
Branches 2927 2930 +3
=======================================
+ Hits 11697 11707 +10
- Misses 1422 1423 +1
Partials 725 725
|
Contributor
sentrivana
approved these changes
Sep 19, 2024
Member
Author
|
@antonpirker ah, sorry 😅 was working on another patch and these failed. Didn't think of looking for an existing PR. |
sentrivana
reviewed
Sep 20, 2024
Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
sentrivana
approved these changes
Sep 23, 2024
Member
|
One of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests were failing for me locally as the timestamps were without
tzinfoand all were assumed UTC whereas my local timezone is BST at the moment.This patch fixes the tests along with faulty/incomplete breadcrumb timestamp parsing logic on py3.7 and py3.8.