Make sure checkins from crons work and keep working#3155
Closed
antonpirker wants to merge 18 commits intoantonpirker/fix-celery-beat-refactoringfrom
Closed
Make sure checkins from crons work and keep working#3155antonpirker wants to merge 18 commits intoantonpirker/fix-celery-beat-refactoringfrom
antonpirker wants to merge 18 commits intoantonpirker/fix-celery-beat-refactoringfrom
Conversation
…irker/fix-crons-checkin-on-success' of github.com:getsentry/sentry-python into antonpirker/fix-crons-checkin-on-success
1a2e690 to
7bf044c
Compare
…:getsentry/sentry-python into antonpirker/fix-crons-checkin-on-success
antonpirker
commented
Jun 12, 2024
| @pytest.fixture | ||
| def init_celery(sentry_init, request): | ||
| def inner(propagate_traces=True, backend="always_eager", **kwargs): | ||
| def inner( |
Contributor
Author
There was a problem hiding this comment.
I updated this init_celery to make sure we can also set monitor_beat_tasks here.
Contributor
Author
|
We have now the old The new one is way easier, and I think the old one is not needed anymore because advancements in Celery. So I think we can move to the new simpler fixture to be used everywhere. |
sentrivana
approved these changes
Jun 12, 2024
Contributor
sentrivana
left a comment
There was a problem hiding this comment.
Looking good. In the longer term we should look into moving the old tests to the new setup too.
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
Contributor
Author
|
Closing in favor of #3176 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After refactoring the Celery Beat integration there was a regression, where the
ok/errorcheck ins for crons where not sent.We reverted the refactoring here: #3144
This PR:
https://github.com/getsentry/sentry-python/pull/3155/files#diff-a05979007fa0398cc22f7b4910ccd3fde27fdea262a6137d1abdc676c633fcdcR75
https://github.com/getsentry/sentry-python/pull/3155/files#diff-6080c59a09cd8a2064cb87c5e2512c0589dda02f0ad2f46c94f774b0e645676fR56
After we have merged this we can revert the revert linked above.
Fixes #3145