Redis Cache Module - 2 - Add Cache Spans#3075
Merged
antonpirker merged 43 commits intoantonpirker/redis-cache-module-1from May 23, 2024
Merged
Redis Cache Module - 2 - Add Cache Spans#3075antonpirker merged 43 commits intoantonpirker/redis-cache-module-1from
antonpirker merged 43 commits intoantonpirker/redis-cache-module-1from
Conversation
…r that python version
sentrivana
approved these changes
May 22, 2024
Contributor
sentrivana
left a comment
There was a problem hiding this comment.
Looking good, see some comments
We started auto-enabling the ClickHouse integration in 2.0+. This led to it getting auto-enabled also for folks using ClickHouse with Django via `django-clickhouse-backend`, but it turns out that the integration doesn't work properly with `django-clickhouse-backend` and leads to `AttributeError: 'Connection' object has no attribute '_sentry_span'`.
…is-cache-module-1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new cache spans and add relevant data to it. See specs here: https://develop.sentry.dev/sdk/performance/modules/caches/
This works for all our instrumented redis clients and also in sync and async code.
Part 2/2 for fixing #2965