Skip to content

Patch eventlet under Sentry SDK#2464

Merged
szokeasaurusrex merged 11 commits intomasterfrom
szokeasaurusrex/patch-eventlet-under-sentry-sdk
Oct 25, 2023
Merged

Patch eventlet under Sentry SDK#2464
szokeasaurusrex merged 11 commits intomasterfrom
szokeasaurusrex/patch-eventlet-under-sentry-sdk

Conversation

@szokeasaurusrex
Copy link
Member

Pull request containing the same changes as #1258, created since #1258 does not allow edits from maintainers and is currently out of date with master, and therefore cannot be merged even though the PR is approved.

From @guiscaranse (original author on #1258):

This patches the eventlet library to allow it to run without issues under the Sentry SDK when using greenlet>=0.5. Eventlet doesn't pin the greenlet dependency and eventlet/eventlet#663 (that's why the sdk runs nicely under Gevent for example). So, the eventlet library itself is not a good marker to whatever the contextvars are broken or not.

This should fix #1036

@szokeasaurusrex szokeasaurusrex enabled auto-merge (squash) October 25, 2023 10:08
@szokeasaurusrex szokeasaurusrex merged commit 39e3556 into master Oct 25, 2023
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/patch-eventlet-under-sentry-sdk branch October 25, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sentry with eventlet

3 participants