Skip to content

feat(metrics): Move minimetrics code to the SDK#2385

Merged
mitsuhiko merged 36 commits intomasterfrom
feature/minimetrics
Sep 21, 2023
Merged

feat(metrics): Move minimetrics code to the SDK#2385
mitsuhiko merged 36 commits intomasterfrom
feature/minimetrics

Conversation

@mitsuhiko
Copy link
Contributor

@mitsuhiko mitsuhiko commented Sep 20, 2023

This moves the minimetrics code from sentry to the SDK.

Todo:

  • move and adapt tests
  • support unicode values for tag values
  • implement gauges as gauges
  • add interface to emit internal metrics for deployment

Changes compared to original minimetrics:

  • client is gone
  • transport and encoder were replaced by a simple function
  • types were changed to better align with the sdk style
  • timing is implemented as a context manager, what was timing is now distribution
  • release, environment and transaction are attached

Fixes getsentry/sentry#55645

Copy link
Contributor

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because Jan said lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Send release and environment alongside custom metrics

3 participants