fix(arq): Fix attribute error on settings, support worker args#2260
Merged
sentrivana merged 1 commit intogetsentry:masterfrom Aug 16, 2023
rossmacarthur:mac/arq-attribute-error
Merged
fix(arq): Fix attribute error on settings, support worker args#2260sentrivana merged 1 commit intogetsentry:masterfrom rossmacarthur:mac/arq-attribute-error
sentrivana merged 1 commit intogetsentry:masterfrom
rossmacarthur:mac/arq-attribute-error
Conversation
Contributor
|
@rossmacarthur Thanks for the fixes! Could you please run the changes through |
Contributor
Author
|
@sentrivana done :) |
sentrivana
approved these changes
Aug 16, 2023
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The arq settings class doesn't necessarily have to have both
functionsandcron_jobsattributes. Additionally it is possible to configure functions and cron jobs by passing them as a keyword argument tocreate_worker, this is now handled.Fixes #2305
Fixes #2306