Add integerations for socket and grpc by hossein-raeisi · Pull Request #1911 · getsentry/sentry-python

hossein-raeisi · 2023-02-18T13:33:57Z

The gRPC integration instruments all incoming requests and outgoing unary-unary, unary-stream grpc requests using grpcio channels.
Use this integration to start or continue transactions for incoming grpc requests, create spans for outgoing requests,
and ensure traces are properly propagated to downstream services.
The Socket integration to create spans for dns resolves and connection creations.

Docs: getsentry/sentry-docs#6327

Implement SocketIntegration; patches socket's getaddrinfo and create_connection and adds spans to them

Implement gRPC ServerInterceptor; starts(or continues) a transaction for each grpc request

hossein-raeisi · 2023-02-20T19:20:58Z

docs pull request

hossein-raeisi · 2023-02-20T19:23:22Z

I think this pull request has reached a stable state, would appreciate a review @sl0thentr0py @antonpirker

… grpc stub Implement gRPC UnaryUnaryClientInterceptor and grpc.UnaryStreamClientInterceptor; starts a span for grpc call and sends propagation headers in metadata

sl0thentr0py · 2023-02-22T15:54:24Z

ty so much for the contribution @Hossain-raeisi , we'll try to get to this next week

antonpirker · 2023-02-22T20:17:53Z

Hey @Hossain-raeisi
Amazing contribution! As @sl0thentr0py said we will have a look next week, we are already very stoked about this!

hossein-raeisi · 2023-02-28T13:41:47Z

Hey!
Any updates @sl0thentr0py @antonpirker ?

antonpirker · 2023-02-28T14:59:39Z

Have not had time yet. Please hang in there.

antonpirker · 2023-03-03T08:51:23Z

Hey @Hossain-raeisi !
At first glance it looks good.
I fixed some smaller things to make CI happy.

Still, there are some errors in CI mostly about typing:
https://github.com/getsentry/sentry-python/actions/runs/4321738769/jobs/7543323597

Could you fix them?
(Ignore the gevent errors, I have to fix those)

hossein-raeisi · 2023-03-04T20:39:43Z

Hi @antonpirker
thanks for the review
I made some changes and hopefully they should solve most of the errors, but I dont think I can do anything about these ones
https://github.com/getsentry/sentry-python/actions/runs/4321738769/jobs/7543323597#step:4:81

hossein-raeisi · 2023-03-13T20:31:50Z

Hey @antonpirker!
do you have any free time in next few days to pair and finish up this pr?

sentry_sdk/integrations/grpc/server.py

antonpirker · 2023-03-29T11:02:00Z

I changed now the setup, that GRPC tests are only run in Python 3.7+ (because the protobuffers in the tests did not work with version installed on older pythons)

Is this fine with you @Oogwey ?

antonpirker · 2023-03-29T12:06:59Z

I have one more ask @Oogwey , could you please rename TestService, TestMessage and test_grpc_server and prefix it with something like Grpc or whatever.
Pytest it trying to collect tests from all files prefixed test_ and all classes prefixed Test so pytest struggles with out code. Thank You!

hossein-raeisi · 2023-03-29T16:30:25Z

I changed now the setup, that GRPC tests are only run in Python 3.7+ (because the protobuffers in the tests did not work with version installed on older pythons)

Is this fine with you @Oogwey ?

alright with me 👍

hossein-raeisi · 2023-03-29T16:46:58Z

I have one more ask @Oogwey , could you please rename TestService, TestMessage and test_grpc_server and prefix it with something like Grpc or whatever. Pytest it trying to collect tests from all files prefixed test_ and all classes prefixed Test so pytest struggles with out code. Thank You!

Done!

antonpirker · 2023-03-30T10:13:33Z

I am not sure why the Python 2.7 tests are suddenly failing, because those are tests you and me did not touch. 🤷 Very strange. (thought it is because of a file called socket.py, but there are other things also failing...

Could you please merge the newest master from getsentry/sentry-python into your branch (or rebase yours on top of it?) Maybe this helps. Thanks @hossein-raeisi

hossein-raeisi · 2023-03-30T10:53:29Z

I am not sure why the Python 2.7 tests are suddenly failing, because those are tests you and me did not touch. shrug Very strange. (thought it is because of a file called socket.py, but there are other things also failing...

Could you please merge the newest master from getsentry/sentry-python into your branch (or rebase yours on top of it?) Maybe this helps. Thanks @hossein-raeisi

strange 🤔
seems like is already merged:

(remote sentry refers to getsentry/sentry-python)

antonpirker · 2023-03-30T11:58:22Z

Hm. Now all the tests pass. I guess it was a GitHub hiccup, because they had problems with Github actions in the last couple of days.

antonpirker · 2023-03-30T12:01:20Z

Congrats and thanks for you patience @hossein-raeisi !

Really great contribution! Thank you so much! We will release this in the next couple of days.

If you would like a little thank you gift please send me your shipping address and t-shirt size to anton.pirker@sentry.io

hossein-raeisi · 2023-03-30T12:39:43Z

Congrats and thanks for you patience @hossein-raeisi !

Really great contribution! Thank you so much! We will release this in the next couple of days.

If you would like a little thank you gift please send me your shipping address and t-shirt size to anton.pirker@sentry.io

thanks, I would love that

antonpirker · 2023-04-04T12:02:17Z

Your contributions have been released @hossein-raeisi : https://github.com/getsentry/sentry-python/releases/tag/1.19.0

feat(integrations) Implement an integration for tracing socket module

cb107fd

Implement SocketIntegration; patches socket's getaddrinfo and create_connection and adds spans to them

hossein-raeisi force-pushed the add-socket-and-grpc-integrations branch 2 times, most recently from 49c8d30 to 61bdaf1 Compare February 20, 2023 16:06

feat(tracing) Implement an interceptor for grpc server

41631e4

Implement gRPC ServerInterceptor; starts(or continues) a transaction for each grpc request

hossein-raeisi force-pushed the add-socket-and-grpc-integrations branch from 61bdaf1 to 41631e4 Compare February 20, 2023 16:08

hossein-raeisi mentioned this pull request Feb 20, 2023

Add socket and grpc integration docs getsentry/sentry-docs#6327

Merged

hossein-raeisi changed the title ~~Draft: Add integerations for socket and grpc~~ Add integerations for socket and grpc Feb 20, 2023

feat(tracing) Implement unary-unary and unary-stream interceptors for…

5c2db86

… grpc stub Implement gRPC UnaryUnaryClientInterceptor and grpc.UnaryStreamClientInterceptor; starts a span for grpc call and sends propagation headers in metadata

hossein-raeisi force-pushed the add-socket-and-grpc-integrations branch from 2ba5f54 to 5c2db86 Compare February 21, 2023 16:40

hossein-raeisi marked this pull request as ready for review February 22, 2023 05:57

antonpirker and others added 5 commits March 3, 2023 09:20

Merge branch 'master' into add-socket-and-grpc-integrations

77a2e06

Fixed httpx mess up

3e35b16

Updated test config

e3194ca

small nitpicking and fixes

84d5b77

Fixed flake8 errors

4a09bf9

antonpirker self-assigned this Mar 3, 2023

hossein-raeisi force-pushed the add-socket-and-grpc-integrations branch from 7f992e3 to 6ce7834 Compare March 5, 2023 12:23

feat(tracing) Add type hints for grpc and socket integrations

01a51d3

hossein-raeisi force-pushed the add-socket-and-grpc-integrations branch from 9573358 to 01a51d3 Compare March 10, 2023 10:38

Merge branch 'master' into add-socket-and-grpc-integrations

3bee0f9

antonpirker suggested changes Mar 28, 2023

View reviewed changes

sentry_sdk/integrations/grpc/server.py Show resolved Hide resolved

antonpirker added 7 commits March 29, 2023 12:12

Some polishing

c31339d

Added missing file

ec855c1

Fixed linting again

f2bfa08

Moved test requirements into tox.ini

8bea90b

Test Grpc only in Python 3.7+

5eed852

Updated test setup

939b184

Trigger ci (because of codecov)

e1bef26

refactor(tracing) Rename grpc's test proto content

d81fe6c

hossein-raeisi force-pushed the add-socket-and-grpc-integrations branch from 510852e to d81fe6c Compare March 29, 2023 16:46

antonpirker added 9 commits March 30, 2023 08:44

Fixed linting

aadf76d

Trigger ci (because of codecov)

6cefb69

Renamed integration to fix import clashes in python 2.7

7b0af47

shame on me

4cff7d9

Fixed unicode problem

5a17619

Prevent linter from breaking tests

e181206

.

fb5e001

Reverted accidental change

6e19ecc

This can not be the solution, something else is wrong.

815b7ef

Renamed _socket back to socket to try if it was a GH problem

53ae75d

antonpirker merged commit 5d9cd4f into getsentry:master Mar 30, 2023

Conversation

hossein-raeisi commented Feb 18, 2023 • edited by antonpirker Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hossein-raeisi commented Feb 20, 2023

Uh oh!

hossein-raeisi commented Feb 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sl0thentr0py commented Feb 22, 2023

Uh oh!

antonpirker commented Feb 22, 2023

Uh oh!

hossein-raeisi commented Feb 28, 2023

Uh oh!

antonpirker commented Feb 28, 2023

Uh oh!

antonpirker commented Mar 3, 2023

Uh oh!

hossein-raeisi commented Mar 4, 2023

Uh oh!

hossein-raeisi commented Mar 13, 2023

Uh oh!

Uh oh!

antonpirker commented Mar 29, 2023

Uh oh!

antonpirker commented Mar 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hossein-raeisi commented Mar 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hossein-raeisi commented Mar 29, 2023

Uh oh!

antonpirker commented Mar 30, 2023

Uh oh!

hossein-raeisi commented Mar 30, 2023

Uh oh!

antonpirker commented Mar 30, 2023

Uh oh!

antonpirker commented Mar 30, 2023

Uh oh!

hossein-raeisi commented Mar 30, 2023

Uh oh!

antonpirker commented Apr 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hossein-raeisi commented Feb 18, 2023 •

edited by antonpirker

Loading

hossein-raeisi commented Feb 20, 2023 •

edited

Loading

antonpirker commented Mar 29, 2023 •

edited

Loading

hossein-raeisi commented Mar 29, 2023 •

edited

Loading