Do not overwrite default for username with email address in Flask-Login integration#1873
Merged
sl0thentr0py merged 2 commits intogetsentry:masterfrom Jan 30, 2023
homeworkprod:patch-1
Merged
Do not overwrite default for username with email address in Flask-Login integration#1873sl0thentr0py merged 2 commits intogetsentry:masterfrom homeworkprod:patch-1
sl0thentr0py merged 2 commits intogetsentry:masterfrom
homeworkprod:patch-1
Conversation
This line seems like a copy/paste error, introduced in 4112000.
sl0thentr0py
approved these changes
Jan 30, 2023
Member
sl0thentr0py
left a comment
There was a problem hiding this comment.
indeed, thx @homeworkprod !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This line seems like a copy/paste error, introduced in 4112000.
The email address is already set a few lines above for "email".
Unless I'm missing some very clever fallback magic, considering the
try/catcharound this, I think this is a mistake and the email address should not be used as username.