Don't log whole event in before_send / event_processor drops#1863
Merged
sl0thentr0py merged 2 commits intomasterfrom Jan 24, 2023
Merged
Don't log whole event in before_send / event_processor drops#1863sl0thentr0py merged 2 commits intomasterfrom
sl0thentr0py merged 2 commits intomasterfrom
Conversation
antonpirker
approved these changes
Jan 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These logger statements probably made sense at an earlier state of the SDK, but now events are sufficiently complex that logging the whole dict makes no sense and cause issues such as the linked issue when large bytes payloads are included.
Fixes #1856