fix: avoid sending empty Baggage header#1507
Merged
sl0thentr0py merged 2 commits intogetsentry:masterfrom Jul 18, 2022
intgr:avoid-empty-Baggage-header
Merged
fix: avoid sending empty Baggage header#1507sl0thentr0py merged 2 commits intogetsentry:masterfrom intgr:avoid-empty-Baggage-header
sl0thentr0py merged 2 commits intogetsentry:masterfrom
intgr:avoid-empty-Baggage-header
Conversation
According to W3C Working Draft spec, the Baggage header must contain at least one value, an empty value is invalid.
Contributor
Author
|
I ran across an HTTP service that breaks when an empty Baggage header is sent by the client. It's also a waste of bandwidth, no data is being communicated. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to W3C Working Draft spec, the
Baggageheader must contain at least one value; header with empty value string is invalid.