-
Notifications
You must be signed in to change notification settings - Fork 589
Description
How do you use Sentry?
Sentry Saas (sentry.io)
Version
1.12.1
Steps to Reproduce
- Pass a
TracesSamplerinstead of settingtraces_sample_rate - Set
_experiments['profiles_sample_rate']to 1.0
Expected Result
Every request with a trace also has a corresponding profile
Actual Result
No profiles are being recorded
P.S. From glancing at the code it doesn't look like there is a hard dependency on the more "dumb" traces_sample_rate over a TracesSampler. It's just that init checks for traces_sample_rate instead of doing the more thorough check of has_tracing_enabled which will check either option.
As a workaround I seem to be able to just pass a dummy fixed sampling rate, since the TracesSampler always takes priority.
P.P.S. Looks like the workaround might not actually work, since I'm still seeing no profiles for traced transactions. Unless they take a while to process. But I will try some alternative sampling methods for the profiler before giving up.