linux: Enable building for Linux platforms with Crashpad.#307
linux: Enable building for Linux platforms with Crashpad.#307jblazquez wants to merge 1 commit intogetsentry:masterfrom
Conversation
|
With your crashpad PR merged, you can also bump the submodule ;-) |
|
@Swatinem, updated the PR with your feedback. |
Swatinem
left a comment
There was a problem hiding this comment.
One last thing, I should have mentioned this earlier:
Please turn on the tests here:
sentry-native/tests/conditions.py
Line 7 in 205e38f
|
@Swatinem before we merge this in, could you please check if the HTTP implementation in Crashpad works now? The last time I checked, Crashpad was not able to make HTTPS requests and generally had troubles with getting requests out. |
|
Adding at least a smoketest for crashpad here: #310 |
|
Thanks Arpad, I updated the tests script. |
|
Looks like CI broke after enabling Crashpad tests on Linux, something related to I'm gonna have to get familiar with the CI setup to understand what's going on, but if you have any ideas please let me know. |
|
Ah, that is just my oversight. I remember we had one of these already. Also I’m surprised that all the compat includes are leaking into sentry. |
|
Crashpad integration tests have moved to #311 |
|
This was done as part of #320 now |
This change fixes a compile error when MemorySanitizer is enabled and also allows sentry-native to be built targeting the Linux platform with the Crashpad backend. Please let me know if you actually don't want to support this backend on Linux I can close this PR.
This depends on the changes here being merged: getsentry/crashpad#15
Fixes #232