Conversation
jan-auer
requested changes
Mar 12, 2020
Member
jan-auer
left a comment
There was a problem hiding this comment.
Excellent implementation! A few smaller changes below.
| if (!dump_path) { | ||
| return; | ||
| } | ||
| // NOTE: there is a special `minidump` envelope item type, however, when |
Member
There was a problem hiding this comment.
There is no special minidump envelope type. This was from an earlier draft of envelopes, but never implemented. Once we finalize the envelopes spec, we can update this.
Contributor
Author
There was a problem hiding this comment.
What I rather meant is this:
sentry-native/src/sentry_envelope.c
Lines 96 to 110 in 99c1159
Member
There was a problem hiding this comment.
I see, completely missed this. Can we remove this type, since it is invalid?
jan-auer
approved these changes
Mar 12, 2020
This was referenced Mar 12, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breakpad will register the signal handler, and write a minidump to disk.
In the callback, we will create an event (to get all the scope and breadcrumbs) and capture that.
In the same callback, we will force a special breakpad transport, similar to the disk transport.
It will serialize the envelope to disk, but also attach the minidump file to that envelope as well.
I’m not too happy with how the cmake files work, but I don’t have any better ideas either, and it works at least :-D