fix(win): make symbolication and modulefinder independent of the system ANSI code page. #1389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…ry and validates the package paths
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
...however, no longer assert that a frame_package exists.
The szExePath generated for actual UTF-8 paths was already filled with mojibake :-) so LoadLibrary couldn't find any local modules. This is actually connected to the symbolication: * in the server, if a module was found, the backend would assign packages to frames based on the instruction address and the module address range * if the module couldn't be found, as was the case previously, it had to use the frame package provided So, now we fixed both and they should overlap.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the primary aspect of #1388.
Instead of using the
dbghelperinterfaces with theAsuffix, which rely on compatible code page settings downstream, we use the wide-char variants and convert them to narrow UTF-8. This completely isolates symbols and paths from any system ANSI code page.The modulefinder was also affected by this in that the
szExePathofMODULEENTRY32W, while storing wide-characters, actually appeared with all CP-foreign characters being replaced with0x3f.While logically those two aren't connected inside the SDK, they do overlap in the processing pipeline:
LoadLibrarycouldn't find a library due to a mangled path coming in fromszExePath), it would accept the package as provided by the frameFurther changes:
PSAPI_VERSION == 2, since we only linkkernel32