fix: update traces_sampler to also take user_data argument
#1346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpnurmi
reviewed
Sep 1, 2025
Collaborator
jpnurmi
left a comment
There was a problem hiding this comment.
Thanks on behalf of downstream SDKs! :) This looks good, no need to inject internal values into the user's sampling context.
jpnurmi
approved these changes
Sep 1, 2025
Collaborator
jpnurmi
left a comment
There was a problem hiding this comment.
The changes look good. I hope @supervacuus is ok with the break.
Member
Author
|
(this would become part of the same release that includes the first Logs implementation for native, so I think bundling this in as a breaking change for native 0.11.0 is fine) |
supervacuus
approved these changes
Sep 2, 2025
Collaborator
supervacuus
left a comment
There was a problem hiding this comment.
Yes, I am not happy that we have to break here, and I would argue that a second option setter + callback type is fine here.
However, the API is marked as experimental, very new, and having two just for the sampler is probably more confusing. So, whiny LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1345