Skip to content

feat: add dynamic sampling context #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoshuaMoelans merged 25 commits into from
Jul 15, 2025
Merged

feat: add dynamic sampling context #1254

JoshuaMoelans merged 25 commits into from
Jul 15, 2025

Conversation

@JoshuaMoelans
Copy link
Member

@JoshuaMoelans JoshuaMoelans commented May 23, 2025 •
edited
Loading

fixes #1141
implemented following the develop docs

  • add sample_rand functionality ( ‼️ breaking ‼️ )
  • collect all attributes (from spec)
  • add DSC to transaction events
  • add DSC to error events
  • make sure we don't need to send it to downstream services with baggage header (docs)
  • add tests
    • new org_id extraction
    • proper DSC handling
    • new sample_rand feature
  • add to docs, also update example in Custom Instrumentation to explain how to send the headers after sentry_transaction_iter_headers

@github-actions
Copy link

github-actions bot commented May 23, 2025 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 2a9bb6a

JoshuaMoelans
JoshuaMoelans commented May 26, 2025
View reviewed changes
JoshuaMoelans
JoshuaMoelans commented Jun 4, 2025
View reviewed changes
JoshuaMoelans
JoshuaMoelans commented Jun 4, 2025
View reviewed changes
@JoshuaMoelans JoshuaMoelans marked this pull request as ready for review June 5, 2025 15:23
@JoshuaMoelans JoshuaMoelans requested a review from supervacuus June 5, 2025 15:24
@supervacuus supervacuus mentioned this pull request Jun 10, 2025
Merged
@supervacuus
Copy link
Collaborator

supervacuus commented Jun 10, 2025

Let's put this on hold until we have clarity regarding #1270.

@supervacuus supervacuus removed their request for review June 11, 2025 08:58
@JoshuaMoelans JoshuaMoelans requested a review from supervacuus July 4, 2025 12:32
supervacuus
supervacuus requested changes Jul 7, 2025
View reviewed changes
Copy link
Collaborator

@supervacuus supervacuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks largely good, with a few nits on edge cases and error handling.

@JoshuaMoelans JoshuaMoelans requested a review from supervacuus July 8, 2025 15:15
@JoshuaMoelans JoshuaMoelans merged commit cbaaf1e into master Jul 15, 2025
56 of 58 checks passed
@JoshuaMoelans JoshuaMoelans deleted the joshua/feat/dsc branch July 15, 2025 09:28
@BrewTestBot BrewTestBot mentioned this pull request Aug 8, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@supervacuus supervacuus supervacuus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adding Dynamic Sampling Context

3 participants

@JoshuaMoelans @supervacuus