feat: add dynamic sampling context#1254
Merged
JoshuaMoelans merged 25 commits intomasterfrom Jul 15, 2025
Merged
Conversation
|
JoshuaMoelans
commented
May 26, 2025
# Conflicts: # CHANGELOG.md
JoshuaMoelans
commented
Jun 4, 2025
JoshuaMoelans
commented
Jun 4, 2025
# Conflicts: # CHANGELOG.md # src/sentry_scope.c
Collaborator
|
Let's put this on hold until we have clarity regarding #1270. |
# Conflicts: # src/sentry_core.c # tests/unit/test_utils.c
supervacuus
requested changes
Jul 7, 2025
Collaborator
supervacuus
left a comment
There was a problem hiding this comment.
This looks largely good, with a few nits on edge cases and error handling.
supervacuus
approved these changes
Jul 9, 2025
# Conflicts: # CHANGELOG.md
1 task
BernhardMarconato
pushed a commit
to elgatosf/sentry-native
that referenced
this pull request
Apr 21, 2026
* initial DSC implementation * add `sample_rand` * fix `sample_rand` generation * fix the fix + add test * update org_id expected size * add test + changelog + sample_rand for traces_sampler * add test + changelog + sample_rand for traces_sampler + dsc for events * add org_id tests * fix CHANGELOG.md * cleanup * post-merge fix * post-merge fix v2 * split up test * fix CHANGELOG.md * org_id handling update * asan overflow fix * add warnings for missing DSC fields * swap `sentry_set_trace` for `sentry_regenerate_trace` * add clarifying note --------- Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1141
implemented following the develop docs
sample_randfunctionality (make sure we don't need to send it to downstream services withbaggageheader (docs)baggageaspect of the DSC Extending Dynamic Sampling Context #1267org_idextractionsample_randfeaturesentry_transaction_iter_headers