feat: add support for Xbox Series X/S.#1100
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1100 +/- ##
=======================================
Coverage 82.62% 82.62%
=======================================
Files 53 53
Lines 7896 7896
Branches 1234 1234
=======================================
Hits 6524 6524
- Misses 1261 1263 +2
+ Partials 111 109 -2 |
JoshuaMoelans
left a comment
There was a problem hiding this comment.
LGTM (didn't inspect cmake files in detail, as discussed in DMs)
PlasmaDev5
left a comment
There was a problem hiding this comment.
All look good to me.
Any improvements i had already have pending reviews to be moved over to this repo after this merge has gone in.
Reminder that this is the public SDK so only changes that rely on public GDK or public samples repo can be added here. |
| set(CMAKE_TRY_COMPILE_PLATFORM_VARIABLES XdkEditionTarget BUILD_USING_BWOI) | ||
|
|
||
| #--- Windows SDK | ||
| set(SDKVersion 10.0.19041.0) |
There was a problem hiding this comment.
According to the GDK documentation, Windows SDK version 10.0.22000+ is required as of October 2023 GDK: https://learn.microsoft.com/en-us/gaming/gdk/_content/gc/getstarted/overviews/sdk-and-tools#windows-software-development-kit-sdk
There was a problem hiding this comment.
We have a follow up change that will auto detect the latest GDK and Windows SDK versions. I believe its just pending the merge of this change
There was a problem hiding this comment.
I'm more surprised this even builds with what should be the "wrong" version of the Windows SDK. Thanks for the heads up about the follow-up change!
4699d94 to
10c73c5
Compare
|
looks good! let's get this merged in |
fixes #1068.