Provide version information in DLL#1076
Merged
supervacuus merged 12 commits intogetsentry:masterfrom Nov 12, 2024
Merged
Conversation
olback
commented
Nov 6, 2024
olback
commented
Nov 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1076 +/- ##
==========================================
- Coverage 82.66% 82.59% -0.07%
==========================================
Files 53 53
Lines 7717 7717
Branches 1213 1213
==========================================
- Hits 6379 6374 -5
- Misses 1227 1230 +3
- Partials 111 113 +2 |
supervacuus
requested changes
Nov 7, 2024
Collaborator
supervacuus
left a comment
There was a problem hiding this comment.
Thanks! There are certainly some users who appreciate this very much.
* moved code to utility function * that function uses the target argument to generate all required files (only manual parameter is the file description) * switched from manual string replacement to `configure_file()` which creates another intermediate file * to generate the final *.rc file we use file(GENERATE) together with `TARGET_FILE_NAME` generator expression to retrieve "OriginFilename" during the generate-time (between configure and build phase). * ensure that unit-tests don't pick up unnecessary resource-sources
supervacuus
approved these changes
Nov 11, 2024
Collaborator
supervacuus
left a comment
There was a problem hiding this comment.
Thanks, LGTM. I made a few minor changes so that we can reuse your code for crashpad.
Please don't merge; I will do this soon.
...because even if we generate static client libraries crashpad_handler.exe and crashpad_wer.dll should still be versioned.
6 tasks
Contributor
|
This PR broke usage of sentry-native as a submodule, e.g. in sentry-flutter: |
Collaborator
Yeah, sorry. Fixed here: #1086 I will release it now. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building sentry-native as a DLL, there is currently no easy way to determine what version it is.
Windows allows you to specify version information in a resource file, the version can then be found in 'Properties' from Explorer. The version can also be queried programatically with
GetFileVersionInfo{A,W}.Here's an example (in Swedish):
