-
-
Notifications
You must be signed in to change notification settings - Fork 203
crashpad crashes when cleaning the database #1064
Copy link
Copy link
Closed
getsentry/crashpad
#115Labels
Bugsomething isn't working as it shouldsomething isn't working as it shouldbackend: crashpadupstreamThe issue is related to an upstream dependencyThe issue is related to an upstream dependency
Metadata
Metadata
Assignees
Labels
Bugsomething isn't working as it shouldsomething isn't working as it shouldbackend: crashpadupstreamThe issue is related to an upstream dependencyThe issue is related to an upstream dependency
Fields
Give feedbackNo fields configured for issues without a type.
This happens in the field:
It seems int
int CrashReportDatabaseWin::CleanDatabase(time_t lockfile_ttl)isn't checking for failedstd::unique_ptr<Metadata> CrashReportDatabaseWin::AcquireMetadata()(which can fail if the metadata_file can't be opened or the following file-lock failed)https://github.com/getsentry/crashpad/blob/59fc31ce00d245d59cff282f5ee8f0785b710a2c/client/crash_report_database_win.cc#L970-L1001
All other functions acquiring metadata check the return value and exit immediately. This should be upstreamed.