Skip to content

crashpad crashes when cleaning the database #1064

@supervacuus

Description

@supervacuus

This happens in the field:

Image

It seems int int CrashReportDatabaseWin::CleanDatabase(time_t lockfile_ttl) isn't checking for failed std::unique_ptr<Metadata> CrashReportDatabaseWin::AcquireMetadata() (which can fail if the metadata_file can't be opened or the following file-lock failed)

https://github.com/getsentry/crashpad/blob/59fc31ce00d245d59cff282f5ee8f0785b710a2c/client/crash_report_database_win.cc#L970-L1001

All other functions acquiring metadata check the return value and exit immediately. This should be upstreamed.

Metadata

Metadata

Assignees

Labels

Bugsomething isn't working as it shouldbackend: crashpadupstreamThe issue is related to an upstream dependency
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions