add TODO comments for sentry_value_as_uint64 + SIZE_MAX

jpnurmi · jpnurmi · commit fb54090e604e · 2025-07-25T10:17:15.000+02:00
diff --git a/src/sentry_envelope.c b/src/sentry_envelope.c
@@ -815,13 +815,17 @@ sentry_envelope_deserialize(const char *buf, size_t buf_len)
             }
             item->payload_len = (size_t)(payload_end - ptr);
         } else {
+            // TODO: sentry_value_as_uint64
+            // https://github.com/getsentry/sentry-native/pull/1301
             int payload_len = sentry_value_as_int32(length);
             if (payload_len < 0) {
                 goto fail;
             }
             item->payload_len = (size_t)payload_len;
         }
         if (item->payload_len > 0) {
+            // TODO: SIZE_MAX
+            // https://github.com/getsentry/sentry-native/pull/1301
             if (ptr + item->payload_len > end
                 || item->payload_len > INT32_MAX - 1) {
                 goto fail;
diff --git a/tests/unit/test_envelopes.c b/tests/unit/test_envelopes.c
@@ -671,6 +671,8 @@ SENTRY_TEST(deserialize_envelope_invalid)
     TEST_CHECK(!sentry_envelope_deserialize("{}\ninvalid\n", 11));
     TEST_CHECK(!sentry_envelope_deserialize("invalid", 7));
     TEST_CHECK(!sentry_envelope_deserialize("{}\n{\"length\":-1}\n", 17));
+    // TODO: SIZE_MAX
+    // https://github.com/getsentry/sentry-native/pull/1301
     char buf[128];
     snprintf(buf, sizeof(buf), "{}\n{\"length\":%d}\n", INT32_MAX);
     TEST_CHECK(!sentry_envelope_deserialize(buf, strlen(buf)));

Original file line number	Diff line number	Diff line change
`@@ -815,13 +815,17 @@ sentry_envelope_deserialize(const char *buf, size_t buf_len)`
`815`	`815`	`}`
`816`	`816`	`item->payload_len = (size_t)(payload_end - ptr);`
`817`	`817`	`} else {`
	`818`	`+ // TODO: sentry_value_as_uint64`
	`819`	`+ // https://github.com/getsentry/sentry-native/pull/1301`
`818`	`820`	`int payload_len = sentry_value_as_int32(length);`
`819`	`821`	`if (payload_len < 0) {`
`820`	`822`	`goto fail;`
`821`	`823`	`}`
`822`	`824`	`item->payload_len = (size_t)payload_len;`
`823`	`825`	`}`
`824`	`826`	`if (item->payload_len > 0) {`
	`827`	`+ // TODO: SIZE_MAX`
	`828`	`+ // https://github.com/getsentry/sentry-native/pull/1301`
`825`	`829`	`if (ptr + item->payload_len > end`
`826`	`830`	`\|\| item->payload_len > INT32_MAX - 1) {`
`827`	`831`	`goto fail;`