fix(plugin-manager): Respect `sourcemap.ignore` values for injecting debugIDs #836

s1gr1d · 2026-01-15T10:49:49Z

In this PR, Nuxt will use the build plugin manager to upload source maps at the end of the build. Currently, it fails because the ignore option is not respected.

injectDebugIds is currently using the "raw" execute function and doesn't pass the --ignore param yet. The functions in the CLI package contain some defaults around what is passed to execute, for example a default ignore:
https://github.com/getsentry/sentry-cli/blob/9f34df859bf2975155aad0fe5c6c423b45c07084/lib/releases/index.ts#L16

The next step is to bring this inject command to the CLI code (CLI PR) so it can be used in the BuildPluginManager.

Related to getsentry/sentry-javascript#18519

…debugIDs

s1gr1d · 2026-01-15T10:51:03Z

packages/bundler-plugin-core/src/utils.ts

+export function serializeIgnoreOptions(ignoreValue: string | string[] | undefined): string[] {
+  const DEFAULT_IGNORE = ["node_modules"];
+
+  const ignoreOptions: string[] = Array.isArray(ignoreValue)
+    ? ignoreValue
+    : typeof ignoreValue === "string"
+    ? [ignoreValue]
+    : DEFAULT_IGNORE;
+
+  return ignoreOptions.reduce(
+    (acc, value) => acc.concat(["--ignore", String(value)]),
+    [] as string[]
+  );
+}


This is a simplified version of: https://github.com/getsentry/sentry-cli/blob/9f34df859bf2975155aad0fe5c6c423b45c07084/lib/helper.ts#L199-L217

packages/bundler-plugin-core/src/build-plugin-manager.ts

Lms24

Sounds reasonable to me. One comment to confirm, otherwise ready to go :)

Lms24 · 2026-01-15T12:02:37Z

packages/bundler-plugin-core/src/utils.ts

+ * Temporary workaround until we expose a function for injecting debug IDs. Currently, we directly call `execute` with CLI args to inject them.
+ */
+export function serializeIgnoreOptions(ignoreValue: string | string[] | undefined): string[] {
+  const DEFAULT_IGNORE = ["node_modules"];


hmm I wonder if including node_modules has any implications but I don't think so: We inject debug ids into emitted bundles, meaning the node_modules required by the bundle should already be in there.

Also, the ignore option for upload also defaults to node_modules, right?

Not ignoring it can result in file import loops (this is what happens in e.g. Nuxt).

And yes, it's also the default option for uploading source maps.

packages/bundler-plugin-core/src/build-plugin-manager.ts

chargome · 2026-01-15T13:19:16Z

packages/bundler-plugin-core/src/utils.ts

+    ? ignoreValue
+    : typeof ignoreValue === "string"
+    ? [ignoreValue]
+    : DEFAULT_IGNORE;


Just wondering if we don't always want to add this ignore? In the sense that a user should likely never inject debug ids in node_modules but they usually want to additionally ignore other paths etc. no?

Good call! I just resembled the existing logic from the CLI here (user-provided value overwrites): https://github.com/getsentry/sentry-cli/blob/a618fb33ddfc3646ac8d5e2391ea1ee6e208b709/lib/releases/index.ts#L159-L161

Either we document, that ignore has a default value of 'node_modules', which gets overwritten or we just always add 'node_modules'. I am leaning towards just better documenting this default value, so it's still possible to overwrite it.

@Lms24 any opinions on that?

So according to this doc, the default is [], which seems like its wrong either way (?).

I am leaning towards just better documenting this default value, so it's still possible to overwrite it.

Me too, because the alternative would be a behaviour break, right? So let's avoid that 😅

the default is [], which seems like its wrong either way

In the JS bundler plugins, this is correct. But this value is passed down a bunch of times:

CLI Bundler Plugins Meta-Framework SDK

adds 'node_modules' as default uses CLI in plugin manager (no defaults) uses bundler plugins (no defaults)

Maybe it's worth applying this default in the bundler plugins already, as we could align the behavior better on this stage.

Only the Plugin Manger uses the CLI under the hood, and there are no defaults otherwise.

Talked offline, created an issue: #838

github-actions · 2026-01-16T08:38:57Z

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

Bug Fixes 🐛

Plugin Manager

Respect sourcemap.ignore values for injecting debugIDs by s1gr1d in #836

Enable "rejectOnError" in debug by s1gr1d in #837

Documentation 📚

Add RELEASE.md to document release process by nicohrubec in #834

Build / dependencies / internal 🔧

(release) Switch from action-prepare-release to Craft by BYK in #831

_{🤖 This preview updates automatically when you update the PR.}

sentry · 2026-01-16T08:42:38Z

packages/bundler-plugin-core/src/build-plugin-manager.ts

+              [
+                "sourcemaps",
+                "inject",
+                ...serializeIgnoreOptions(options.sourcemaps?.ignore),


Bug: The injectDebugIds function defaults to ignoring node_modules, but uploadSourcemaps does not, causing source maps to be uploaded without debug IDs.
_{Severity: HIGH}

Suggested Fix

Ensure the uploadSourcemaps function applies the same default ignore behavior as injectDebugIds. When options.sourcemaps?.ignore is undefined, it should default to ignoring ["node_modules"]. This will align the set of files that have debug IDs injected with the set of files that are uploaded as source maps.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: packages/bundler-plugin-core/src/build-plugin-manager.ts#L561 Potential issue: There is an inconsistency in how default ignore behavior is handled between `injectDebugIds` and `uploadSourcemaps`. When `options.sourcemaps?.ignore` is undefined, `injectDebugIds` defaults to ignoring `node_modules`. However, `uploadSourcemaps` does not apply this default in either its direct upload or prepare modes. This causes source maps from `node_modules` to be uploaded without the corresponding debug IDs being injected. As a result, the association between the source code and the error in Sentry is broken for these files, rendering the uploaded source maps unusable and wasting upload bandwidth.

_{Did we get this right? 👍 / 👎 to inform future reviews.}

fix(plugin-manager): Respect sourcemap.ignore values for injecting …

985b74a

…debugIDs

s1gr1d requested review from Lms24 and chargome January 15, 2026 10:49

s1gr1d commented Jan 15, 2026

View reviewed changes

sentry bot reviewed Jan 15, 2026

View reviewed changes

packages/bundler-plugin-core/src/build-plugin-manager.ts Outdated Show resolved Hide resolved

s1gr1d mentioned this pull request Jan 15, 2026

feat(nuxt): Inject debug IDs only once at build end getsentry/sentry-javascript#18561

Draft

fix order

c7eaa5e

sentry bot reviewed Jan 15, 2026

View reviewed changes

packages/bundler-plugin-core/src/build-plugin-manager.ts Show resolved Hide resolved

Lms24 approved these changes Jan 15, 2026

View reviewed changes

s1gr1d mentioned this pull request Jan 15, 2026

feat(js-lib): Add sourceMaps.inject() for injecting debug IDs getsentry/sentry-cli#3088

Open

fix tests

19271c1

sentry bot reviewed Jan 15, 2026

View reviewed changes

packages/bundler-plugin-core/src/build-plugin-manager.ts Show resolved Hide resolved

chargome reviewed Jan 15, 2026

View reviewed changes

s1gr1d mentioned this pull request Jan 15, 2026

(breaking) Change default for sourcemaps.ignore to ["node_modules"] #838

Open

Merge branch 'main' into sig/add-ignore-to-inject

7518e3a

sentry bot reviewed Jan 16, 2026

View reviewed changes

s1gr1d merged commit 8e53019 into main Jan 16, 2026
25 checks passed

s1gr1d deleted the sig/add-ignore-to-inject branch January 16, 2026 09:52

fix(plugin-manager): Respect sourcemap.ignore values for injecting debugIDs #836

fix(plugin-manager): Respect sourcemap.ignore values for injecting debugIDs #836

Conversation

s1gr1d commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

s1gr1d Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Lms24 left a comment

Choose a reason for hiding this comment

Uh oh!

Lms24 Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

s1gr1d Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chargome Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

s1gr1d Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lms24 Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

s1gr1d Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

s1gr1d Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 16, 2026

Semver Impact of This PR

📋 Changelog Preview

Bug Fixes 🐛

Plugin Manager

Documentation 📚

Build / dependencies / internal 🔧

Uh oh!

sentry bot Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix(plugin-manager): Respect `sourcemap.ignore` values for injecting debugIDs #836

fix(plugin-manager): Respect `sourcemap.ignore` values for injecting debugIDs #836

s1gr1d commented Jan 15, 2026 •

edited

Loading

s1gr1d Jan 15, 2026 •

edited

Loading

s1gr1d Jan 15, 2026 •

edited

Loading