Skip to content

revert: Testing additional bundlers#729

Merged
Lms24 merged 2 commits intogetsentry:mainfrom
timfish:timfish/revert/additional-bundlers
Apr 23, 2025
Merged

revert: Testing additional bundlers#729
Lms24 merged 2 commits intogetsentry:mainfrom
timfish:timfish/revert/additional-bundlers

Conversation

@timfish
Copy link
Copy Markdown
Collaborator

@timfish timfish commented Apr 18, 2025

This PR reverts #725 because:

  • I broke the NODE_MAJOR_VERSION code and it was ending up as NaN due to the leading v
  • No tests were actually checking the rollup4 or vite6 output

Now I'm testing Vite 6 in this configuration, it does not work. It resolves rollup to rollup@3 whereas it needs rollup@4. I think we can only test these vastly different versions with multiple node_modules install directories and a different approach.

@timfish timfish requested review from Lms24 and lforst April 18, 2025 11:58
@Lms24 Lms24 merged commit 2d796d7 into getsentry:main Apr 23, 2025
26 checks passed
@timfish timfish deleted the timfish/revert/additional-bundlers branch February 17, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants