Skip to content

ref(core): Refactor core integrations to functional style#9916

Merged
mydea merged 2 commits intodevelopfrom
fn/core-functional-integrations
Dec 20, 2023
Merged

ref(core): Refactor core integrations to functional style#9916
mydea merged 2 commits intodevelopfrom
fn/core-functional-integrations

Conversation

@mydea
Copy link
Copy Markdown
Member

@mydea mydea commented Dec 19, 2023

Also make a small adjustment to the legacy converter util to ensure setupOnce() is callable with or without arguments, to remain stable.

@mydea mydea requested a review from AbhiPrasad December 19, 2023 13:43
@mydea mydea self-assigned this Dec 19, 2023
@mydea mydea force-pushed the fn/core-functional-integrations branch 2 times, most recently from 68061b9 to 785d712 Compare December 19, 2023 14:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 19, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 75.35 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 66.75 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 60.34 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.41 KB (-0.04% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.02 KB (-0.02% 🔽)
@sentry/browser - Webpack (gzipped) 21.71 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 72.73 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 64.44 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 30.73 KB (-0.02% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 22.82 KB (+0.14% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 202.43 KB (-0.08% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 92.55 KB (-0.14% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 67.61 KB (-0.18% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 33.59 KB (+0.03% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 67.12 KB (-0.01% 🔽)
@sentry/react - Webpack (gzipped) 21.75 KB (-0.03% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 83.9 KB (-0.02% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 48.57 KB (-0.03% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 16.35 KB (0%)

Also make a small adjustment to the legacy converter util to ensure `setupOnce()` is callable with or without arguments, to remain stable.

fix types...
@mydea mydea force-pushed the fn/core-functional-integrations branch from 785d712 to 1cf0597 Compare December 19, 2023 15:28
@mydea mydea merged commit 74a12d9 into develop Dec 20, 2023
@mydea mydea deleted the fn/core-functional-integrations branch December 20, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants