fix: Wrap all console log instances in console sandbox#9662
Merged
Conversation
AbhiPrasad
approved these changes
Nov 27, 2023
Contributor
size-limit report 📦
|
7005f10 to
df253ad
Compare
Lms24
approved these changes
Nov 27, 2023
Member
Lms24
left a comment
There was a problem hiding this comment.
LGTM! I wasn't aware (before last week) that this is such a problem but it totally makes sense.
I Was a bit unsure about us sandboxing console.error calls (e.g. Node, Sveltekit) that were just made to mimic default behaviour but after thinking for a bit, it also makes sense. We already caught the error in these situations anyway, so no need for CaptureConsole to come in again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9640