ref: Replace global __DEBUG_BUILD__ type with DEBUG_BUILD const in individual packages#9657
Merged
ref: Replace global __DEBUG_BUILD__ type with DEBUG_BUILD const in individual packages#9657
__DEBUG_BUILD__ type with DEBUG_BUILD const in individual packages#9657Conversation
__DEBUG_BUILD__ type with DEBUG_BUILD constant in individual packages__DEBUG_BUILD__ type with DEBUG_BUILD const in individual packages
Contributor
size-limit report 📦
|
AbhiPrasad
approved these changes
Nov 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref getsentry/sentry-capacitor#249
We had a global & ambient type declaration for
__DEBUG_BUILD__in@sentry/types. This caused problems when people included multiple versions of@sentry/typesin their builds because such bindings may only be declared once. This seemed to have affected mostly consuming packages that also depended on@sentry/types: getsentry/sentry-capacitor#249We fix this by just having a constant in each individual package that is equal to
__DEBUG_BUILD__having its ambient declaration only apply locally. We cannot have only one such constant in e.g.@sentry/utilsbecause there could be complications with regard to tree shaking.