feat(core): Add addEventProcessor method#9554
Merged
Conversation
Contributor
size-limit report 📦
|
AbhiPrasad
suggested changes
Nov 20, 2023
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
We need migration docs in MIGRATION.md
Member
Author
|
Good point! Small note, with the upcoming hub & scope changes this also means that we'll update this to put the event processors on the isolation scope instead of the client, but that doesn't affect this PR (as it is a future change, that we can do under the hood in v8) |
f8ed063 to
5b64856
Compare
AbhiPrasad
approved these changes
Nov 22, 2023
And deprecate `addGlobalEventProcessor()` and `getGlobalEventProcessors()`. In v8, all event processors will be on the client only, streamlining this a bit and preventing global "pollution".
5b64856 to
4dc2e3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And deprecate
addGlobalEventProcessor()andgetGlobalEventProcessors().In v8, all event processors will be on the client only, streamlining this a bit and preventing global "pollution".
Closes #9082