fix(replay): ensure replay_id is not added to DSC if session expired#9359
Merged
fix(replay): ensure replay_id is not added to DSC if session expired#9359
replay_id is not added to DSC if session expired#9359Conversation
Contributor
size-limit report 📦
|
billyvg
approved these changes
Oct 25, 2023
AbhiPrasad
approved these changes
Oct 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed we still sometimes see "too long sessions", and it seems this is because of errors being tagged with a replay long after the session expired. After some digging, this may be because we do not check session expiration when adding the
replay_idto the DSC. This PR fixes this.I thought about adding a test for this, but feels this is a lot of work with all the timing issues etc., so I figure this is OK to do as-is, as this is pretty straightforward... WDYT?