revert: Expose sampleTransaction export from core#9208
Merged
Conversation
Contributor
size-limit report 📦
|
5f09844 to
87b0884
Compare
lforst
approved these changes
Oct 11, 2023
This was previously exported so we can use it in node-experimental, but turns out we can't do that anyhow because we need to sample in OTEL. This has not yet been released, so in order to avoid exporting stuff we don't need public let's revert this export. (I'll leave the actual restructuring of moving this into a dedicated file in, though, because I think it still makes sense that way)
87b0884 to
c98eb8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was previously exported so we can use it in node-experimental, but turns out we can't do that anyhow because we need to sample in OTEL. This has not yet been released, so in order to avoid exporting stuff we don't need public let's revert this export. (I'll leave the actual restructuring of moving this into a dedicated file in, though, because I think it still makes sense that way).