feat(astro): Add server and client SDK init functions#9189
Merged
Conversation
mydea
reviewed
Oct 6, 2023
mydea
reviewed
Oct 9, 2023
package.json
Outdated
| "yalc:publish": "lerna run yalc:publish" | ||
| }, | ||
| "volta": { | ||
| "node": "16.19.0", |
Member
There was a problem hiding this comment.
Actually, thinking about this, can we do this in a separate PR?
Member
Author
There was a problem hiding this comment.
Unfortunately, this was already merged with #9187 :(
(this PR still needs a rebase)
I agree it would have been better to split this into a separate PR.
Member
There was a problem hiding this comment.
ah, right, well whatever, not a big deal ;)
0e4b107 to
cdf46ec
Compare
mydea
approved these changes
Oct 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
initfunctions for the server and client side of the Astro SDK with tests.For now, most of what these functions do is set the SDK metadata. On the client side, we add BrowserTracing, similarly to Next/SvelteKit.
Contrary to our other SDKs, we'll not hard-require users to call these functions but internally call them in the Sentry Astro integration (not to be mistaken for a Sentry SDK
Integration) which users will add to their Astro config. For this internal call, we'll apply sensible defaults. Users can manually override the internal SDK init by addingsentry.(client|server).config.tsfiles.ref #9182