fix(ember): Drop undefined config values#9175
Merged
Conversation
Contributor
size-limit report 📦
|
lforst
approved these changes
Oct 4, 2023
Lms24
approved these changes
Oct 4, 2023
It seems to trip something up somewhere when config is undefined, so we just remove these here to avoid this.
316f030 to
e2a1205
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems to trip something up somewhere when config is undefined, so we just remove these here to avoid this. These options are serialized etc. so there may be something weird going on there...
Fixes #9168